Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor decoding, part 4 #267

Merged
merged 5 commits into from
Feb 16, 2024
Merged

Refactor decoding, part 4 #267

merged 5 commits into from
Feb 16, 2024

Commits on Feb 15, 2024

  1. browse tool: some cleanups 

    for whatever reason, mypy started to complain recently. Maybe this has
something to do with the recent switch to `InquirerPy`...

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Florian Jost <[email protected]>
    @andlaus
    andlaus committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    46d6196 View commit details
    Browse the repository at this point in the history

  2. make matching request parameters truly positionable 

    i.e., if they are non-byte aligned their value will no longer feature
garbage at the beginning and/or at the end. Besides this, their values
are now integers, which is more intuitive IMO.

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Florian Jost <[email protected]>
    @andlaus
    andlaus committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    35d1437 View commit details
    Browse the repository at this point in the history

  3. streamline ParamLengthInfoType.decode_from_pdu() a bit 

    Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Florian Jost <[email protected]>
    @andlaus
    andlaus committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    d643820 View commit details
    Browse the repository at this point in the history

  4. DiagCodedType: rename _extract_internal_value() to `_extract_atomic… 

    …_value()`

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Florian Jost <[email protected]>
    @andlaus
    andlaus committed Feb 15, 2024
    Configuration menu
    Copy the full SHA
    59324c3 View commit details
    Browse the repository at this point in the history

Commits on Feb 16, 2024

  1. move the method for extracting atomic values to DecodeState 

    thanks to [at]kayoub5 for the proposal.

Signed-off-by: Andreas Lauser <[email protected]>
Signed-off-by: Florian Jost <[email protected]>
    @andlaus
    andlaus committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    7259501 View commit details
    Browse the repository at this point in the history