fix: return SVGs as UInt8Array instead of Buffer
#767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, SVGs are returned as `Buffer`s from `renderMermaid()`, which is almost compatible with `UInt8Array`, but not 100%, which was causing TypeScript 5.6 to throw an error. See: mermaid-js#746
MindaugasLaganeckas
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 Summary
Currently, SVGs are returned as
Buffers fromrenderMermaid(), which is almost compatible withUInt8Array, but not 100%, which was causing TypeScript 5.6 to throw an error.See: #746
This should resolve the CI failure in #746
📏 Design Decisions
N/A
📋 Tasks
Make sure you
masterbranch