Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input size should be at bottom with graph_dir='BT' #92

Open
sarzeaud opened this issue Apr 28, 2023 · 1 comment
Open

input size should be at bottom with graph_dir='BT' #92

sarzeaud opened this issue Apr 28, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@sarzeaud
Copy link

When the graph is drawn using graph_dir='BT', the input size of each layer should be at bottom and output size at top of each block. This would give a much natural graph, the input arrow of each block arriving on the input line, and the output arrow living it from the output line.

@mert-kurttutan
Copy link
Owner

I agree this is visually more convenient.

The update needed for this should be very small

It can be done putting conditional html like labelling on the following function

https://github.com/mert-kurttutan/torchview/blob/main/torchview/computation_graph.py#L385

I would really appreciate any contribution.

@mert-kurttutan mert-kurttutan added help wanted Extra attention is needed good first issue Good for newcomers enhancement New feature or request labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants