-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[UI] Navbar is not closing on click getting started in mobile view #1888
Comments
This issue has been labeled with 'component/ui'. 🧰 Here are docs on Contributing to Meshery UI. 🎨 Here is the Meshery UI Figma File File. Lastly, here are docs on Contributing to Meshery's End-to-End Tests Using Cypress.
|
Hi @amitamrutiya, could this be assigned to me. Would like to work on it |
Hi @amitamrutiya |
@agamjotpanesar Thanks for showing interest in solving this issue. We are assigning tasks in chronological order, so you can find a different issue to work on. @hymmns, you're good to go—let's make this happen! |
I managed to fix it with vanilla JS while testing in DevTools. TipThe `display` of the navbar's ul needs to be set to _none_ once the _Getting Started_ li is clicked_.Hope it helps :) Please let me know if my behavior is ok. It's the first time I do this, and I thought it's ok as a tip since someone else has been already assigned. Thank you! |
@porobertdev Thanks for the input. |
@amitamrutiya Please let me know if this fixes the issue or if there's any other comment kindly drop. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Description
In mobile view, when we click on "Getting Started," the navbar menu does not close.
Expected Behavior
In mobile view, the navbar should close when "Getting Started" is clicked.
Screenshots
Environment:
Contributor Guides and Handbook
The meshery.io website uses Jekyll and GitHub Pages. Site content is found under the
master
branch.The text was updated successfully, but these errors were encountered: