Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LB-1102, LB-1610, LB-945: Revamp Top Entity stats pages #2937

Merged
merged 38 commits into from
Jul 31, 2024

Commits on Jul 9, 2024

  1. LB-1102: Improve entity stats on mobile

    Put the graph at the top of the page and the list of entities below that.
    The left/right split that we currently have is unusable on mobile and pretty ugly on desktop, so...
    MonkeyDo committed Jul 9, 2024
    Configuration menu
    Copy the full SHA
    d77c209 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. Configuration menu
    Copy the full SHA
    e4b1919 View commit details
    Browse the repository at this point in the history
  2. TopEntity graph: Custom tooltips

    To allow wrapping text especially for narrow mobile phone screens, otherwise the tooltip does not serve its primary purpose on mobile
    MonkeyDo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    62d00a1 View commit details
    Browse the repository at this point in the history
  3. Housekeeping!

    MonkeyDo committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    67f4528 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2024

  1. Configuration menu
    Copy the full SHA
    8fbe413 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Configuration menu
    Copy the full SHA
    1591f51 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2024

  1. Configuration menu
    Copy the full SHA
    ba2a0dc View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Lint less

    code more
    MonkeyDo committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    5b1ac25 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c23e460 View commit details
    Browse the repository at this point in the history
  3. TopEntity graph: add artist in tooltip

    if it is in the data
    MonkeyDo committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    bb9c743 View commit details
    Browse the repository at this point in the history
  4. TopEntity graph: custom bar component

    foreignObject allows us to use HTML in the SVG, to use links as well as using CSS to handle text wrapping and ellipses.
    
    On mobile try to save some space by moving elements around a bit.
    MonkeyDo committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    08ec9ce View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Configuration menu
    Copy the full SHA
    e294362 View commit details
    Browse the repository at this point in the history
  2. TopEntity page: use ReleaseCard component where applicable

    Replaces the ListenCard component for releases and release-groups
    MonkeyDo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    f28db67 View commit details
    Browse the repository at this point in the history
  3. TopEntity graph: Add axis at the top too

    We removed the graph tooltips which don't work well with links in the bars , considering we were able to put almost all the information directly in the graph bars. The only missing piece of data is the listen count, so an axis at the top helps read that piece of data.
    Listens count also available on hover using html title
    MonkeyDo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    4ff501e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6124cd0 View commit details
    Browse the repository at this point in the history
  5. TopEntity: Some final tweaks

    MonkeyDo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    08ae6ca View commit details
    Browse the repository at this point in the history
  6. Lint

    in my bellybutton
    MonkeyDo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    8eb726b View commit details
    Browse the repository at this point in the history
  7. TopEntity: Fewer axes ticks

    MonkeyDo committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    651e113 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2024

  1. TopEntity graph: adapt to fewer results

    Calculate the height of the graph based on the number of results, for example for your weekly stats if you don't have 25 artists yet.
    MonkeyDo committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ad508b0 View commit details
    Browse the repository at this point in the history
  2. TopEntity graph: modify colors

    also show number of listens for each bar instead of the position (#1, #2, etc.)
    MonkeyDo committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    296978e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6afd0f7 View commit details
    Browse the repository at this point in the history
  4. TopTracks: Add recordingMSID

    currently not sent by the frontend, see LB-1609
    MonkeyDo committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    acf1ecc View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2024

  1. ReleaseCard: don't link to entities we don't have MBIDs for

    We have some releases, artists and recordings that are unmapped, meaning we don't have MBIDs for them. In that case, link to the pre-filled search page  rather than linking to e.g. `/artist/undefined`
    MonkeyDo committed Jul 24, 2024
    Configuration menu
    Copy the full SHA
    94a51f7 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. TopEntity graph: more fine details

    Tweak the color and size of the bars a bit more, and make the ticks and grid lines for integers only (no sense in showing fractions of a listen...)
    MonkeyDo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    a1985de View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    86a50bc View commit details
    Browse the repository at this point in the history
  3. UserEntity graph: Fix number of grid lines

    Didn't realize we could use the same definition as for the tick value, which is exactly what I wanted.
    MonkeyDo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    d156e6d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2fdbd44 View commit details
    Browse the repository at this point in the history
  5. TopEntity graph: Add chart position to tooltip text

    I wanted to put that information somewhere, as it is impractical to add it to the bar text itself.
    At least we have somewhere to put that piece of data.
    MonkeyDo committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    5406f08 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    3cd2254 View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Remove unused ref

    MonkeyDo committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    50369a8 View commit details
    Browse the repository at this point in the history
  2. TopEntity page: Fix ListenCard grid

    "display:grid" with items set to be 400px minimum we causing overflow issues because grid items do not honor min-width.
    Flexbox to the rescue once again!
    
    Also two-line ellipsis for listencard title like we do elsewhere.
    MonkeyDo committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    7a6bd87 View commit details
    Browse the repository at this point in the history
  3. Only show entity count header if entityCount exists

    In global stats we don't have an entityCount so we should just hide the header
    
    + remove useless row + col-xs-12 wrappers which achieve nothing.
    MonkeyDo committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    36b3c65 View commit details
    Browse the repository at this point in the history
  4. Remove useless row + col-xs-12 wrappers which achieve nothing.

    Using a .row wrapper with a single .col-xs-12 inside basically does nothing other than making the HTML less readable.
    MonkeyDo committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    d07d682 View commit details
    Browse the repository at this point in the history
  5. TopEntity: Fix pagination buttons

    Good old off-by-one error !
    MonkeyDo committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    b2adcc8 View commit details
    Browse the repository at this point in the history
  6. TopEntity pagination: Fix max number of pages

    Made a mistake previously by setting the number of pages to the max possible number of pages, instead of capping it at that number.
    MonkeyDo committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    867d6e8 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    26d364d View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Configuration menu
    Copy the full SHA
    05215be View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ea43e1c View commit details
    Browse the repository at this point in the history