-
-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LB-1102, LB-1610, LB-945: Revamp Top Entity stats pages #2937
Commits on Jul 9, 2024
-
LB-1102: Improve entity stats on mobile
Put the graph at the top of the page and the list of entities below that. The left/right split that we currently have is unusable on mobile and pretty ugly on desktop, so...
Configuration menu - View commit details
-
Copy full SHA for d77c209 - Browse repository at this point
Copy the full SHA d77c209View commit details
Commits on Jul 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e4b1919 - Browse repository at this point
Copy the full SHA e4b1919View commit details -
TopEntity graph: Custom tooltips
To allow wrapping text especially for narrow mobile phone screens, otherwise the tooltip does not serve its primary purpose on mobile
Configuration menu - View commit details
-
Copy full SHA for 62d00a1 - Browse repository at this point
Copy the full SHA 62d00a1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 67f4528 - Browse repository at this point
Copy the full SHA 67f4528View commit details
Commits on Jul 11, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 8fbe413 - Browse repository at this point
Copy the full SHA 8fbe413View commit details
Commits on Jul 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 1591f51 - Browse repository at this point
Copy the full SHA 1591f51View commit details
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ba2a0dc - Browse repository at this point
Copy the full SHA ba2a0dcView commit details
Commits on Jul 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5b1ac25 - Browse repository at this point
Copy the full SHA 5b1ac25View commit details -
Configuration menu - View commit details
-
Copy full SHA for c23e460 - Browse repository at this point
Copy the full SHA c23e460View commit details -
Configuration menu - View commit details
-
Copy full SHA for bb9c743 - Browse repository at this point
Copy the full SHA bb9c743View commit details -
TopEntity graph: custom bar component
foreignObject allows us to use HTML in the SVG, to use links as well as using CSS to handle text wrapping and ellipses. On mobile try to save some space by moving elements around a bit.
Configuration menu - View commit details
-
Copy full SHA for 08ec9ce - Browse repository at this point
Copy the full SHA 08ec9ceView commit details
Commits on Jul 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e294362 - Browse repository at this point
Copy the full SHA e294362View commit details -
TopEntity page: use ReleaseCard component where applicable
Replaces the ListenCard component for releases and release-groups
Configuration menu - View commit details
-
Copy full SHA for f28db67 - Browse repository at this point
Copy the full SHA f28db67View commit details -
TopEntity graph: Add axis at the top too
We removed the graph tooltips which don't work well with links in the bars , considering we were able to put almost all the information directly in the graph bars. The only missing piece of data is the listen count, so an axis at the top helps read that piece of data. Listens count also available on hover using html title
Configuration menu - View commit details
-
Copy full SHA for 4ff501e - Browse repository at this point
Copy the full SHA 4ff501eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6124cd0 - Browse repository at this point
Copy the full SHA 6124cd0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 08ae6ca - Browse repository at this point
Copy the full SHA 08ae6caView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8eb726b - Browse repository at this point
Copy the full SHA 8eb726bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 651e113 - Browse repository at this point
Copy the full SHA 651e113View commit details
Commits on Jul 23, 2024
-
TopEntity graph: adapt to fewer results
Calculate the height of the graph based on the number of results, for example for your weekly stats if you don't have 25 artists yet.
Configuration menu - View commit details
-
Copy full SHA for ad508b0 - Browse repository at this point
Copy the full SHA ad508b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 296978e - Browse repository at this point
Copy the full SHA 296978eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6afd0f7 - Browse repository at this point
Copy the full SHA 6afd0f7View commit details -
currently not sent by the frontend, see LB-1609
Configuration menu - View commit details
-
Copy full SHA for acf1ecc - Browse repository at this point
Copy the full SHA acf1eccView commit details
Commits on Jul 24, 2024
-
ReleaseCard: don't link to entities we don't have MBIDs for
We have some releases, artists and recordings that are unmapped, meaning we don't have MBIDs for them. In that case, link to the pre-filled search page rather than linking to e.g. `/artist/undefined`
Configuration menu - View commit details
-
Copy full SHA for 94a51f7 - Browse repository at this point
Copy the full SHA 94a51f7View commit details
Commits on Jul 25, 2024
-
TopEntity graph: more fine details
Tweak the color and size of the bars a bit more, and make the ticks and grid lines for integers only (no sense in showing fractions of a listen...)
Configuration menu - View commit details
-
Copy full SHA for a1985de - Browse repository at this point
Copy the full SHA a1985deView commit details -
Configuration menu - View commit details
-
Copy full SHA for 86a50bc - Browse repository at this point
Copy the full SHA 86a50bcView commit details -
UserEntity graph: Fix number of grid lines
Didn't realize we could use the same definition as for the tick value, which is exactly what I wanted.
Configuration menu - View commit details
-
Copy full SHA for d156e6d - Browse repository at this point
Copy the full SHA d156e6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2fdbd44 - Browse repository at this point
Copy the full SHA 2fdbd44View commit details -
TopEntity graph: Add chart position to tooltip text
I wanted to put that information somewhere, as it is impractical to add it to the bar text itself. At least we have somewhere to put that piece of data.
Configuration menu - View commit details
-
Copy full SHA for 5406f08 - Browse repository at this point
Copy the full SHA 5406f08View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3cd2254 - Browse repository at this point
Copy the full SHA 3cd2254View commit details
Commits on Jul 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 50369a8 - Browse repository at this point
Copy the full SHA 50369a8View commit details -
TopEntity page: Fix ListenCard grid
"display:grid" with items set to be 400px minimum we causing overflow issues because grid items do not honor min-width. Flexbox to the rescue once again! Also two-line ellipsis for listencard title like we do elsewhere.
Configuration menu - View commit details
-
Copy full SHA for 7a6bd87 - Browse repository at this point
Copy the full SHA 7a6bd87View commit details -
Only show entity count header if entityCount exists
In global stats we don't have an entityCount so we should just hide the header + remove useless row + col-xs-12 wrappers which achieve nothing.
Configuration menu - View commit details
-
Copy full SHA for 36b3c65 - Browse repository at this point
Copy the full SHA 36b3c65View commit details -
Remove useless row + col-xs-12 wrappers which achieve nothing.
Using a .row wrapper with a single .col-xs-12 inside basically does nothing other than making the HTML less readable.
Configuration menu - View commit details
-
Copy full SHA for d07d682 - Browse repository at this point
Copy the full SHA d07d682View commit details -
Configuration menu - View commit details
-
Copy full SHA for b2adcc8 - Browse repository at this point
Copy the full SHA b2adcc8View commit details -
TopEntity pagination: Fix max number of pages
Made a mistake previously by setting the number of pages to the max possible number of pages, instead of capping it at that number.
Configuration menu - View commit details
-
Copy full SHA for 867d6e8 - Browse repository at this point
Copy the full SHA 867d6e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26d364d - Browse repository at this point
Copy the full SHA 26d364dView commit details
Commits on Jul 30, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 05215be - Browse repository at this point
Copy the full SHA 05215beView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea43e1c - Browse repository at this point
Copy the full SHA ea43e1cView commit details