Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Doesn't take into account proper time difference when cells are in colspan #145

Open
dipamsen opened this issue Oct 2, 2024 · 3 comments · May be fixed by #146
Open

[BUG] Doesn't take into account proper time difference when cells are in colspan #145

dipamsen opened this issue Oct 2, 2024 · 3 comments · May be fixed by #146
Assignees
@dipamsen
Labels
bug

Comments

@dipamsen
Copy link
Contributor

dipamsen commented Oct 2, 2024 •
edited
Loading

gyft/timetable/extractor.py

Lines 106 to 109 in 705462d

prev = Course(code=code, name=course_names.get(code, ""), day=day,
start_time=timings[index],
location=location)
prev.duration = cell_duration

In this code, it uses timings[index] as start time of the course, where index is the index of the cell in the row. However, this is not correct when the ERP timetable contains colspans in earlier cells, because that has to be taken into account (timings[index + no of skipped cells due to colspan])

This causes issue in the generated time table:

image

image
@proffapt proffapt moved this to Todo in Metakgp Dreams Oct 2, 2024
@proffapt proffapt added the bug label Oct 2, 2024
@proffapt
Copy link
Member

proffapt commented Oct 2, 2024

Would you like to fix it?

@dipamsen
Copy link
Contributor Author

dipamsen commented Oct 2, 2024

Would you like to fix it?

Sure, will do

@proffapt
Copy link
Member

proffapt commented Oct 2, 2024

Assigned to you

@dipamsen dipamsen linked a pull request Oct 2, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dipamsen dipamsen

Labels
bug
Projects
Metakgp Dreams
Status: In Review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix timing logic in presence of colspans dipamsen/gyft
2 participants
@dipamsen @proffapt