Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapt e2e tests to account for Ironic deployed by IrSO #2112

Open
dtantsur opened this issue Nov 27, 2024 · 3 comments
Open

Adapt e2e tests to account for Ironic deployed by IrSO #2112

dtantsur opened this issue Nov 27, 2024 · 3 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/ci Categorizes issue or PR as related to CI or testing. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@dtantsur
Copy link
Member

Currently, the tests assume that Ironic is either started locally or is deployed by BMO's deploy.sh. When deployed by IrSO, it looks differently, so at least re-pivoting tests fail.

/kind ci
/help
@metal3-io-bot
Copy link
Contributor

@dtantsur:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Currently, the tests assume that Ironic is either started locally or is deployed by BMO's deploy.sh. When deployed by IrSO, it looks differently, so at least re-pivoting tests fail.

/kind ci
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added kind/ci Categorizes issue or PR as related to CI or testing. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Nov 27, 2024
@tuminoid tuminoid mentioned this issue Nov 27, 2024
Open
@tuminoid
Copy link
Member

We also need some keywords to run tests with IRSO. Create metal3-io/project-infra#920 in project infra for that.

@dtantsur
Copy link
Member Author

dtantsur commented Dec 4, 2024

/triage accepted

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. and removed needs-triage Indicates an issue lacks a `triage/foo` label and requires one. labels Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/ci Categorizes issue or PR as related to CI or testing. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dtantsur @tuminoid @metal3-io-bot