Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ironic-pod contains ironic-auth volume but doesn't use it #41

Closed
matthewei opened this issue May 29, 2024 · 7 comments
Closed

Ironic-pod contains ironic-auth volume but doesn't use it #41

matthewei opened this issue May 29, 2024 · 7 comments
Labels
invalid This doesn't seem right needs-triage Indicates an issue lacks a `triage/foo` label and requires one.

Comments

@matthewei
Copy link

image
Please check it.

@metal3-io-bot
Copy link
Contributor

This issue is currently awaiting triage.
If Metal3.io contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added the needs-triage Indicates an issue lacks a `triage/foo` label and requires one. label May 29, 2024
@dtantsur
Copy link
Member

It's actually used but only in the distributed case: https://github.com/metal3-io/ironic-standalone-operator/blob/main/pkg/ironic/containers.go#L242-L245 (for JSON RPC).

We will need its htpasswd part in all cases once there is some resolution for metal3-io/baremetal-operator#1685

@Rozzii
Copy link
Member

Rozzii commented May 29, 2024

Just adding here the ironic-image related PR metal3-io/ironic-image#506

@Rozzii Rozzii added the invalid This doesn't seem right label May 29, 2024
@matthewei
Copy link
Author

yes, I see.

@Rozzii
Copy link
Member

Rozzii commented Jun 5, 2024

@matthewei can we close this issue?

@matthewei
Copy link
Author

matthewei commented Jun 5, 2024

/close

@matthewei
Copy link
Author

@matthewei can we close this issue?

yes, why not

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right needs-triage Indicates an issue lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

4 participants