Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Create new file with status and inspect annotations merged #1981

Closed
wants to merge 1 commit into from
Closed

🌱 Create new file with status and inspect annotations merged #1981

wants to merge 1 commit into from

Conversation

SafeEHA
Copy link

@SafeEHA SafeEHA commented Oct 3, 2024 •
edited
Loading

This PR merges status Annotations and Inspect Annotations file into one file now titled annotations in Baremetal-operator docs:

This issue fixes #314 in metal3-docs repo

@Rozzii @dtantsur kindly review this, I'll also like to confirm if this file should be moved to metal3-docs repo?

@metal3-io-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign lentzi90 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 3, 2024
@metal3-io-bot
Copy link
Contributor

Hi @SafeEHA. Thanks for your PR.

I'm waiting for a metal3-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 3, 2024
@SafeEHA SafeEHA changed the title Create new file with status and inspect annotations merged 🌱 Infra/Tests/Other: 🌱 (:seedling:) Create new file with status and inspect annotations merged Oct 3, 2024
@SafeEHA SafeEHA force-pushed the annotations-patch branch from c42cd56 to bed2767 Compare October 3, 2024 09:42
@SafeEHA SafeEHA changed the title Infra/Tests/Other: 🌱 (:seedling:) Create new file with status and inspect annotations merged Create new file with status and inspect annotations merged 🌱 (:seedling:) Oct 3, 2024
@SafeEHA SafeEHA changed the title Create new file with status and inspect annotations merged 🌱 (:seedling:) 🌱 Create new file with status and inspect annotations merged Oct 3, 2024
@SafeEHA SafeEHA mentioned this pull request Oct 3, 2024
Open
@tuminoid
Copy link
Member

tuminoid commented Oct 3, 2024

I think the point was not moving them around in here, but to move these to metal3-docs to be part of user-guide, and then point there from here.
/hold

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 3, 2024
@SafeEHA
Copy link
Author

SafeEHA commented Oct 3, 2024

Thanks for pointing this out @dtantsur, i'll do just that now

@SafeEHA SafeEHA closed this Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honza honza Awaiting requested review from honza

@zhouhao3 zhouhao3 Awaiting requested review from zhouhao3

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User-guide: migrate BareMetalHost and HardwareData API docs from BMO
3 participants
@SafeEHA @metal3-io-bot @tuminoid