Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dead links at nodes-machines-and-hosts.md #441

Open
tuminoid opened this issue Jun 13, 2024 · 7 comments · May be fixed by #488
Open

Fix dead links at nodes-machines-and-hosts.md #441

tuminoid opened this issue Jun 13, 2024 · 7 comments · May be fixed by #488
Assignees
@geekrypter
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue is ready to be actively worked on.

Comments

@tuminoid
Copy link
Member 

| FILE: ./design/nodes-machines-and-hosts.md
| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html
| 
| 8 links checked.
| 
| ERROR: 1 dead links found!
| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html → Status: 404

/triage accepted
/help
/good-first-issue

Split from #328
@metal3-io-bot
Copy link
Contributor

@tuminoid:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

| FILE: ./design/nodes-machines-and-hosts.md
| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html
| 
| 8 links checked.
| 
| ERROR: 1 dead links found!
| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html → Status: 404

/triage accepted
/help
/good-first-issue

Split from #328

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@metal3-io-bot metal3-io-bot added triage/accepted Indicates an issue is ready to be actively worked on. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 13, 2024
@Rozzii Rozzii moved this from Backlog to MISC WIP in Metal3 - Roadmap Jun 28, 2024
@Rozzii Rozzii moved this from MISC WIP to Backlog in Metal3 - Roadmap Jun 28, 2024
@ayushrakesh
Copy link
Contributor

@tuminoid

| FILE: ./design/nodes-machines-and-hosts.md
| [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html

Is this is the correct link?
https://release-0-1.cluster-api.sigs.k8s.io/common_code/machine_controller.html

@tuminoid
Copy link
Member Author

tuminoid commented Jul 1, 2024

@tuminoid

| FILE: ./design/nodes-machines-and-hosts.md | [✖] https://kubernetes-sigs.github.io/cluster-api/common_code/machine_controller.html

Is this is the correct link? https://release-0-1.cluster-api.sigs.k8s.io/common_code/machine_controller.html

That probably point to the version we originally linked to, but the current version we should link to is at https://cluster-api.sigs.k8s.io/developer/architecture/controllers/machine

Do you agree @dtantsur ?

@metal3-io-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues will close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@metal3-io-bot metal3-io-bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 29, 2024
@tuminoid
Copy link
Member Author

/remove-lifecycle stale

@metal3-io-bot metal3-io-bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 30, 2024
@geekrypter
Copy link
Contributor

Hi @tuminoid, can I work on this issue?

Also, can you confirm if https://cluster-api.sigs.k8s.io/developer/architecture/controllers/machine is the correct link as mentioned earlier?

@tuminoid
Copy link
Member Author

tuminoid commented Dec 9, 2024

IMO it is.

/assign @geekrypter

@geekrypter geekrypter linked a pull request Dec 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geekrypter geekrypter

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. triage/accepted Indicates an issue is ready to be actively worked on.
Projects
Metal3 - Roadmap
Status: Backlog
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dead link in nodes-machines-and-hosts.md geekrypter/metal3-docs
4 participants
@tuminoid @geekrypter @metal3-io-bot @ayushrakesh