Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for mmonit https addresses #30

Open
SyBernot opened this issue Apr 11, 2017 · 3 comments
Open

add support for mmonit https addresses #30

SyBernot opened this issue Apr 11, 2017 · 3 comments

Comments

@SyBernot
Copy link

Our mmonit uses https, looking at the template http is hardcoded, you could create a toggle for http/https but all the mmonit vars are only used in this one place might I suggest just using a $mmonit_connect_string instead of trying to assemble it, it makes the template more flexible and less error prone.

$mmonit_connect_string =>'https://foo:[email protected]:8083/collector',

set mmonit <%= @mmonit_connect_string %>

also having an additional config variable stuffed in the template would prove useful
$mmonit_extra_config => ['check process apache with pidfile /usr/local/apache/logs/httpd.pid', ' start program = "/etc/init.d/httpd start"'],

<% mmonit_extra_config.each do |line| %>
<%= line %>
<% end %>

@FlorentPoinsaut
Copy link
Collaborator

Hi!

Thank you for your suggestion.
Could you please make a PR with your modifications?
Then I would be pleased to integrate it.

Thank you in advance.

Regards,

@nospoe
Copy link

nospoe commented Sep 10, 2018

Hi,

I see still no updates since April. If you grant me permissions to push a branch to the repo and create a PR I could add the $mmonit_connect_string as I am in great need of it.

Or maybe add an extra parameter like $mmonit_address_https and another if statement in monitrc template.

Regards,
George

@FlorentPoinsaut
Copy link
Collaborator

Hi,
This repository is no longer maintained.
You can find a new compatible module with HTTPs for M/Monit here: https://forge.puppet.com/soli/monit
Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants