From f78b505ccb941953b11baba1b3f0436a220bd726 Mon Sep 17 00:00:00 2001 From: Morgan Ludtke Date: Tue, 5 Mar 2024 20:01:19 -0600 Subject: [PATCH] fix: github workflow fixes --- .github/workflows/cypress_public.yml | 8 ++++---- api/prisma/seed-helpers/listing-factory.ts | 2 +- package.json | 2 +- sites/partners/src/lib/listings/formTypes.ts | 2 +- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/cypress_public.yml b/.github/workflows/cypress_public.yml index 6c719788e4..ce542ef284 100644 --- a/.github/workflows/cypress_public.yml +++ b/.github/workflows/cypress_public.yml @@ -59,8 +59,8 @@ jobs: - name: yarn in root dir run: yarn - - name: yarn in backend/core dir - working-directory: ./backend/core + - name: yarn in api dir + working-directory: ./api run: yarn - name: Check postgres @@ -73,7 +73,7 @@ jobs: PGPASSWORD: bloom - name: Setup backend - run: yarn test:backend:core:dbsetup + run: yarn test:backend:new:dbsetup:withseed env: PGHOST: 127.0.0.1 PGPASSWORD: bloom @@ -96,7 +96,7 @@ jobs: with: working-directory: ./sites/public build: yarn build - start: yarn dev:listings, yarn start + start: yarn dev:new-backend, yarn start wait-on: 'http://localhost:3100/jurisdictions' record: false # set this value to true to record videos in cypress cloud for debugging purposes - skip passing tests env: diff --git a/api/prisma/seed-helpers/listing-factory.ts b/api/prisma/seed-helpers/listing-factory.ts index ea055ddb80..75a541321b 100644 --- a/api/prisma/seed-helpers/listing-factory.ts +++ b/api/prisma/seed-helpers/listing-factory.ts @@ -39,7 +39,7 @@ export const listingFactory = async ( const reservedCommunityType = await reservedCommunityTypeFactoryGet( prismaClient, jurisdictionId, - optionalParams.reservedCommunityType, + optionalParams?.reservedCommunityType, ); return { createdAt: new Date(), diff --git a/package.json b/package.json index db764f2c95..f98bde157d 100644 --- a/package.json +++ b/package.json @@ -57,7 +57,7 @@ "test:backend:new:e2e": "cd api && yarn jest --config ./test/jest-e2e.config.js --detectOpenHandles", "test:backend:new:cov": "cd api && yarn jest --config ./test/jest-with-coverage.config.js --detectOpenHandles --logHeapUsage", "test:backend:new:dbsetup": "cd api && yarn db:migration:run", - "test:backend:new:dbsetup:withseed": "cd api && yarn db:migration:run && yarn db:seed:staging --jurisdictionName Bay Area", + "test:backend:new:dbsetup:withseed": "cd api && yarn db:migration:run && yarn db:seed:staging", "backend:new:install": "cd api && yarn install", "prettier": "prettier --write \"./**/*.{js,jsx,ts,tsx,json}\"" }, diff --git a/sites/partners/src/lib/listings/formTypes.ts b/sites/partners/src/lib/listings/formTypes.ts index 391b02ad99..5d56890c90 100644 --- a/sites/partners/src/lib/listings/formTypes.ts +++ b/sites/partners/src/lib/listings/formTypes.ts @@ -75,7 +75,7 @@ export type FormListing = Omit & { whereApplicationsDroppedOff?: ApplicationAddressTypeEnum | AnotherAddressEnum whereApplicationsPickedUp?: ApplicationAddressTypeEnum | AnotherAddressEnum whereApplicationsMailedIn?: ApplicationAddressTypeEnum | AnotherAddressEnum - isExternal: boolean + // isExternal: boolean } export const addressTypes = {