Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Case fixes #1

Open
wants to merge 120 commits into
base: case-fix-rebase
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
120 commits
Select commit Hold shift + click to select a range
5342d25
Fixing symbolic links, removing stale folder, adding a cert document …
Feb 24, 2020
669e41f
Issue #17
smitaraut Feb 25, 2020
3da313c
Adding a dev stream to the generated YAML. (#104)
mew2057 Feb 28, 2020
8407e8a
Merge branch 'v1.1.0' into sidecars
smitaraut Feb 28, 2020
cc6e54c
fix typo in error messages (#119)
deeghuge Feb 28, 2020
05f861d
Merge branch 'v1.1.0' into sidecars
smitaraut Feb 28, 2020
c9f14b8
Merge pull request #108 from smitaraut/sidecars
mew2057 Feb 28, 2020
c5b14af
Adding timeout and worker-threads to provisioner command line (#130)
smitaraut Mar 13, 2020
c3677f9
Fix check if only operator is running
deeghuge Mar 11, 2020
9ca45e6
changing default namespace to ibm-spectrum-scale-csi-driver
deeghuge Mar 11, 2020
d6799a0
Merge pull request #138 from deeghuge/snap
deeghuge Mar 17, 2020
ac3fa92
fix provisioner name
deeghuge Mar 17, 2020
b643cee
Merge pull request #139 from deeghuge/example
deeghuge Mar 18, 2020
0bb82ba
Adding KC doc link.
Feb 26, 2020
eef1795
Updating the OperatorHub doc.
Feb 26, 2020
8f328ab
Fixing repo links for 1.1.0 in CRD.
Feb 26, 2020
3cc6e31
Updating Documentation Links.
Mar 19, 2020
45681fb
Changing verbiage and adding support statement.
Mar 19, 2020
2a4517a
Fixing numbering.
Mar 19, 2020
6d3ee56
Fixing linter errors
Mar 19, 2020
890d1ec
Bumping GUI doc.
Mar 19, 2020
f2e3e62
Removing RTD links.
Mar 20, 2020
36a53c3
Changed support statement.
Mar 20, 2020
7286c8d
Updating README with KC links: 1.2.5 - Must provide accurate and cons…
Mar 20, 2020
4a873c1
Fixing status to conform to cert.
Mar 20, 2020
10a9e68
Restoring 1.0.0 in olm directory (probably going to break the build).
Apr 2, 2020
fae8ae5
Implemented first pass of bundling playbook, creates both the operat…
Apr 2, 2020
0fcb04c
Repaired file naming for the redhat bundle.
Apr 2, 2020
6aa7002
Reinstating linters for verify operator.
Apr 2, 2020
7311f50
Fixing image name for redhat bundling.
Apr 3, 2020
e9d75a7
Fixing linter errors and suggestions from the cloud team.
Apr 7, 2020
e3599ab
Trying to figure out why the travis build is broken.
Apr 7, 2020
bc1d670
Working on fixing cv linter
Apr 7, 2020
026f36b
repo name breaks internal stuff.
Apr 7, 2020
c8a8111
Adding a link to Makefile in cloudpak dir.
Apr 7, 2020
87d8055
Switching to physical Makefile in cloudpak.
Apr 7, 2020
8cde888
Fixing README for CASE.
Apr 7, 2020
361319d
Merge branch 'remediation-cert' into case-fixes
Apr 7, 2020
244f1fc
Fixing prereqs.
Apr 7, 2020
7c35c4f
Reverting to operators, currently fails linter.
Apr 7, 2020
3680946
Ran Generator.
Apr 7, 2020
0549979
Fixing symbolic links.
Apr 8, 2020
3653d6b
Moving README and creating symbolic link in case bundle.
Apr 8, 2020
f1fb65d
Adding resource limits
Apr 8, 2020
1de6f85
Merge branch 'olm-bundling' into case-fixes
Apr 8, 2020
4c8a8d7
Fixing Custom Resource Detection.
Apr 8, 2020
00db4d4
Adding a fix to travis to resolve symlinks.
Apr 8, 2020
24d5a3f
Removing cloudpak-static.
Apr 8, 2020
f1280f9
Running Generator.
Apr 8, 2020
67e4c95
cloudpak => cloudpak-static
Apr 8, 2020
f3e296d
Trying to debug the file resoulution problem in files/deploy/crds/c…
Apr 8, 2020
db46fcb
Somehow missed this.
Apr 8, 2020
fc4ef0f
Removing build rule from Makefile.
Apr 8, 2020
aac43c1
Changing setNamespace command.
Apr 8, 2020
3e32f12
Adding createNamespace back.
Apr 8, 2020
eab74cc
Removing setNamespace.
Apr 8, 2020
9283465
Trying to fix validation schema for crd.
Apr 9, 2020
8627e70
Running generator.
Apr 9, 2020
6724b79
Fixing CR name in tests.
Apr 9, 2020
b2dad63
Adding createnamespace back.
Apr 9, 2020
70cc7cb
Fixing delete option.
Apr 9, 2020
f305175
Removing namespace deletion.
Apr 9, 2020
fe23d16
Removing deprecation.
Apr 9, 2020
55635d0
createNamespaces works at least.
Apr 9, 2020
891f5f2
Trying to figure out the delete failure.
Apr 9, 2020
3b3171a
Adding a log printout to the test, I think the finalizer is hanging.
Apr 9, 2020
c22865f
adding another log output, trying to capture the source of the hang.
Apr 9, 2020
3ffc837
Trying new pre-install.
Apr 9, 2020
a82d79f
Changing up install.sh
Apr 9, 2020
c874578
Trying new watches config to see if we can fix the test issue.
Apr 9, 2020
54062db
Fixing image location for testing.
Apr 9, 2020
081976d
Adding some debug to the wait.
Apr 13, 2020
71d7a52
Trying a different debug message.
Apr 13, 2020
e950f9e
Copying debug to oper-wait
Apr 13, 2020
a6264fe
fixing a typo in oper-wait
Apr 13, 2020
8877d9f
removing opr-wait.
Apr 13, 2020
5a12bd3
Fixing test so secret failure doesn't crash operator.
Apr 13, 2020
bc4c26c
Merge branch 'dev' into case-fixes
Apr 13, 2020
8079121
Swapping operator execution order.
Apr 13, 2020
69eadb7
Setting the image pull to always for debugging.
Apr 13, 2020
c07f172
Adding a set -x to the pre-install.
Apr 13, 2020
b9588bf
Removing set -x replacing with cat.
Apr 13, 2020
0a985c2
Changing up pre-install tests.
Apr 13, 2020
c197f8c
Adding a purge for the operator.
Apr 13, 2020
7e1a798
trying to diagnose the deployment issue.
Apr 13, 2020
e94c444
Adding a patch to the csiscaleoperator.
Apr 13, 2020
2a97688
Removing if statement.
Apr 13, 2020
c85c98e
removing purge.
Apr 13, 2020
87716c3
Manually calling delete function in test.
Apr 13, 2020
ae967cf
bumping operator test version to see if that changes the playbook get…
Apr 13, 2020
f893817
Had the wrong API group set for SCC.
Apr 14, 2020
d43aeca
Fixing test case.
Apr 14, 2020
c412dac
Revertingg operator image.
Apr 14, 2020
efe3e4f
Adding override for metrics.
Apr 14, 2020
1db8510
Adjusting pre-install.sh to fix error.
Apr 14, 2020
90e23f5
Adding a namespace check again.
Apr 14, 2020
1cc0731
Forgot to delete the Custom Resource
Apr 14, 2020
ca95150
Trying a different if formulation.
Apr 14, 2020
ed4d1d6
Trying another if statement.
Apr 14, 2020
aaff13c
Figured out why the preinstall failure was happening.
Apr 14, 2020
0d7796a
Trying to patch out the finalizer.
Apr 14, 2020
dd8ae17
Removing more finalizers.
Apr 14, 2020
493341f
The CR delete can hit problems?
Apr 14, 2020
f11005a
Reformatting yaml for yamllint.
Apr 15, 2020
7b155dc
Running Generator.
Apr 15, 2020
6392f93
Setting indent-sequences to whatever, because it screws up the autom…
Apr 15, 2020
76ee24f
Reorganizing travis fixing a rule.
Apr 15, 2020
0ab9f3b
Fixing linter errors.
Apr 15, 2020
6902b3c
Reverting travis build order.
Apr 15, 2020
8e22089
Fixing cr file name.
Apr 15, 2020
0eb2b97
Merge branch 'case-fixes' of github.com:mew2057/ibm-spectrum-scale-cs…
Apr 21, 2020
a5f8dd5
Readding the cr file.
Apr 21, 2020
5a9d411
Removing CR Again
Apr 21, 2020
108d00f
Merge branch 'operator-version-bump' into case-fixes
Apr 27, 2020
7dd5040
Adding specificity to SCC documentation.
Apr 27, 2020
1cc7896
Bumping to v1 from betav1.
Apr 27, 2020
ae92e54
Addressing linter issues.
Apr 27, 2020
7c6f3c3
Merge branch 'operator-version-bump' into case-fixes
Apr 27, 2020
44b747f
Attempting to repair osdk-scorecard
Apr 28, 2020
1a84064
Merge branch 'operator-version-bump' into case-fixes
Apr 30, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,3 +29,56 @@ This operator does not require any pod security requirements.

# SecurityContextConstraints Requirements
The operator maintains the Security Context Constraints, removing the required restraints when the operator is uninstalled.

The installed SCC is as follows, please note this is a jinja2 template applied by the operator:

``` YAML
kind: SecurityContextConstraints
apiVersion: security.openshift.io/v1
metadata:
annotations:
kubernetes.io/description: allow hostpath and host network to be accessible
generation: 1
name: csiaccess
selfLink: /apis/security.openshift.io/v1/securitycontextconstraints/csiaccess
readOnlyRootFilesystem: false
requiredDropCapabilities:
- KILL
- MKNOD
- SETUID
- SETGID
runAsUser:
type: RunAsAny
seLinuxContext:
type: RunAsAny
supplementalGroups:
type: RunAsAny
volumes:
- configMap
- downwardAPI
- emptyDir
- hostPath
- persistentVolumeClaim
- projected
- secret
allowHostDirVolumePlugin: true
allowHostIPC: false
allowHostNetwork: true
allowHostPID: false
allowHostPorts: false
allowPrivilegeEscalation: true
allowPrivilegedContainer: true
allowedCapabilities: []
defaultAddCapabilities: null
fsGroup:
type: MustRunAs
groups:
- system:authenticated
{% if csiaccess_users|length > 0 %}
users:
{% for user in csiaccess_users %}
- "{{user}}"
{% endfor %}
{% endif %}

```
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ overrides:
reduceTo: WARNING
rule: NoPrivilegedContainers

- reason: Using default values and DROP ALL capabilities. Did not make GA time for explicit defitinition.
- reason: Using default values and DROP ALL capabilities.
reduceTo: WARNING
rule: PodSecurityContextDefined

Expand All @@ -32,7 +32,7 @@ overrides:
rule: ContainerHasLivenessProbe

- reason: pull-secret can be provided in CR
reduceTo: WARNING
reduceTo: INFO
rule: ServiceAccountHasPullSecret

- reason: File is auto-generated, outside of our control.
Expand Down
2 changes: 1 addition & 1 deletion operator/.osdk-scorecard.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@ scorecard:
namespace: "ibm-spectrum-scale-csi-driver"
cr-manifest:
- "deploy/crds/csiscaleoperators.csi.ibm.com_cr.yaml"
csv-path: "deploy/olm-catalog/ibm-spectrum-scale-csi-operator/2.0.0/ibm-spectrum-scale-csi-operator.v2.0.0.clusterserviceversion.yaml"
csv-path: "deploy/olm-catalog/ibm-spectrum-scale-csi-operator/1.1.0/ibm-spectrum-scale-csi-operator.v1.1.0.clusterserviceversion.yaml"
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
---
apiVersion: apiextensions.k8s.io/v1beta1
apiVersion: apiextensions.k8s.io/v1
kind: CustomResourceDefinition
metadata:
labels:
Expand Down
1 change: 1 addition & 0 deletions operator/deploy/operator.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ spec:
cpu: 50m
memory: 50Mi
securityContext:
privileged: false
capabilities:
drop:
- ALL
Expand Down