moved constants TX_APPROVED and TX_DECLINED from AbstractResponseData…

…Mapper to ResponseDataMapperInterface
mewebstudio · Dec 10, 2023 · 2c549ff · 2c549ff
1 parent 334300b
commit 2c549ff
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 11 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -115,11 +115,6 @@ parameters:
 			count: 1
 			path: src/Factory/PosFactory.php
 
-		-
-			message: "#^Access to undefined constant Mews\\\\Pos\\\\DataMapper\\\\ResponseDataMapper\\\\ResponseDataMapperInterface\\:\\:TX_APPROVED\\.$#"
-			count: 1
-			path: src/Gateways/AbstractGateway.php
-
 		-
 			message: "#^Parameter \\#2 \\$rawPaymentResponseData of method Mews\\\\Pos\\\\DataMapper\\\\ResponseDataMapper\\\\GarantiPosResponseDataMapper\\:\\:map3DPaymentData\\(\\) expects array\\{Order\\: array\\<string, array\\<string, string\\|null\\>\\|string\\>, Response\\: array\\<string, string\\>, Transaction\\: array\\<string, array\\<string, string\\>\\|string\\>\\}\\|null, array\\<string, mixed\\>\\|null given\\.$#"
 			count: 1

diff --git a/src/DataMapper/ResponseDataMapper/AbstractResponseDataMapper.php b/src/DataMapper/ResponseDataMapper/AbstractResponseDataMapper.php
@@ -18,12 +18,6 @@
 
 abstract class AbstractResponseDataMapper implements ResponseDataMapperInterface
 {
-    /** @var string */
-    public const TX_APPROVED = 'approved';
-
-    /** @var string */
-    public const TX_DECLINED = 'declined';
-
     /** @var string */
     public const PROCEDURE_SUCCESS_CODE = '00';
 

diff --git a/src/DataMapper/ResponseDataMapper/ResponseDataMapperInterface.php b/src/DataMapper/ResponseDataMapper/ResponseDataMapperInterface.php
@@ -7,4 +7,9 @@
 
 interface ResponseDataMapperInterface extends PaymentResponseMapperInterface, NonPaymentResponseMapperInterface
 {
+    /** @var string */
+    public const TX_APPROVED = 'approved';
+
+    /** @var string */
+    public const TX_DECLINED = 'declined';
 }