Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use flags for language selection #397

Open
rafamanzo opened this issue Dec 29, 2016 · 1 comment · May be fixed by #409
Open

Use flags for language selection #397

rafamanzo opened this issue Dec 29, 2016 · 1 comment · May be fixed by #409
Labels
Design Sprint feature question

Comments

@rafamanzo
Copy link
Member

rafamanzo commented Dec 29, 2016 •
edited
Loading

Replaces part of #366.

It gives a better visual feedback to the user on what this navbar section is responsible for.

On the other hand how do we handle some conflicts from countries with the same language? Such as Brazil and Portugal or USA and Great Britain.

Maybe we might need a third option.

If we do decide to follow the flags solution we might look to use flags from some library such as http://flag-icon-css.lip.is/. Also there is a open discussion regarding how this change affects the acceptance tests at #392. Please have both in mind.
@rafamanzo rafamanzo mentioned this issue Dec 29, 2016
Open
3 tasks
@vitorbaraujo
Copy link
Contributor

Me and @oliveiraMarcelo are working on this issue.

@vitorbaraujo vitorbaraujo linked a pull request May 4, 2017 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Design Sprint feature question
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using flags for language selection MES2017/prezento
2 participants
@rafamanzo @vitorbaraujo