Merge pull request #1404 from mfts/fix/dataroom-group-custom-link

fix: update group permissions for deeply nested files
mfts · Nov 28, 2024 · 06ba286 · 06ba286
2 parents b1ce6fd + 7117435
commit 06ba286
Showing 1 changed file with 28 additions and 31 deletions.
diff --git a/components/datarooms/groups/group-permissions.tsx b/components/datarooms/groups/group-permissions.tsx
@@ -453,37 +453,34 @@ export default function ExpandableTable({
 
         // Ensure all parent folders are viewable if the item is being set to viewable
         // and downloadable if the item is being set to downloadable
-        // if (updatedPermissions.view || updatedPermissions.download) {
-        //   parents.forEach((parent) => {
-        //     changes[parent.id] = {
-        //       view: updatedPermissions.view || parent.permissions.view,
-        //       download:
-        //         updatedPermissions.download || parent.permissions.download,
-        //       itemType: parent.itemType,
-        //     };
-        //   });
-
-        // } else {
-        // If turning off view, recalculate parent permissions
-        [...parents].reverse().forEach((parent) => {
-          const someSubItemViewable = parent.subItems?.some((subItem) =>
-            subItem.id === item.id
-              ? updatedPermissions.view
-              : subItem.permissions.view,
-          );
-          const someSubItemDownloadable = parent.subItems?.some((subItem) =>
-            subItem.id === item.id
-              ? updatedPermissions.download
-              : subItem.permissions.download,
-          );
-
-          changes[parent.id] = {
-            view: someSubItemViewable || false,
-            download: someSubItemDownloadable || false,
-            itemType: parent.itemType,
-          };
-        });
-        // }
+        if (updatedPermissions.view) {
+          parents.forEach((parent) => {
+            changes[parent.id] = {
+              view: true, // Always enable view for parent folders
+              download: parent.permissions.download, // Maintain existing download permission
+              itemType: parent.itemType,
+            };
+          });
+        } else {
+          // If turning off view, recalculate parent permissions
+          [...parents].reverse().forEach((parent) => {
+            const otherChildren =
+              parent.subItems?.filter((subItem) => subItem.id !== item.id) ||
+              [];
+            const someSubItemViewable = otherChildren.some(
+              (subItem) => subItem.permissions.view,
+            );
+            const someSubItemDownloadable = otherChildren.some(
+              (subItem) => subItem.permissions.download,
+            );
+
+            changes[parent.id] = {
+              view: someSubItemViewable,
+              download: someSubItemDownloadable,
+              itemType: parent.itemType,
+            };
+          });
+        }
 
         return changes;
       };