Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error not thrown for non-minimally encoded stack integers #16

Closed
mulllhausen opened this issue May 17, 2015 · 1 comment
Closed

error not thrown for non-minimally encoded stack integers #16

mulllhausen opened this issue May 17, 2015 · 1 comment

Comments

@mulllhausen
Copy link

hi, just running the following script in webbtc.com/scripts and its not throwing an error when it should be:

input: ff0080
output: OP_NEGATE OP_NEGATE

the middle 0x00 is redundant, and since OP_NEGATE calls CScriptNum with fRequireMinimal the core client would throw an error here. it would be good to at least put a warning so that others will be aware that this script will not evaluate correctly in production.

also, thanks for the webbtc script tool - i have found it very useful!

cheers,
peter

@mhanne
Copy link
Owner

mhanne commented May 22, 2015

Hi Peter,

good point, all the verification flags are now enabled by default and you can disable them separately. This works with an input script of 01, for example, to trigger verify_minimaldata.

But unfortunately your specific example still doesn't work, see lian/bitcoin-ruby#168.

@mhanne mhanne closed this as completed May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants