-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Full Compatibility with Monolog 3.6 #17
Conversation
Thanks for this @hirasso, very true I've struggled to get to updating it to latest versions of stuff so your efforts are appreciated! Not sure what you mean on the 'weird comments', I couldn't see anything in the changes that take out anything that looked odd. That said, I did at some point use IDEs other than VS Code, in particular I remember one of them (PHP Storm maybe?) that used to do something odd with comments. You mention Actions too, there's some already, aren't they doing what you suggest? Or did I miss something? |
Hey @markheydon! Great to know you're open to my contribution! I saw the action notification about the failing tests. Could we update the PHP version in the action to 8.2? Since Monolog ^3 requires at least PHP 8.1, I figure most users of this package likely keep their PHP updated. Regarding the code comments I deleted, I also believe they're related to PHP Storm. One example: //<editor-fold desc="Magic Methods"> Also, it's possible the code coverage dropped below 100% in my PR since I'm not familiar with coverage tools. However, I prioritize writing tests for critical components, so I don't think it's a big issue. I prefer keeping my repos free of coverage report batches. |
I've ditched the idea of using WP_CLI together with Monolog logs, so I'll close this PR. Turns out there is a much simpler solution with simply using |
Thanks for the update @hirasso, was good to have some interest in the project while it lasted though! |
Warning: This PR is huge.
I'm opening it here to let you have a look if you are interested. If it's just too many changes for your taste, I'll continue to maintain my fork for my use.
$logger->notice()
should be resolved toWP_CLI::log
instead ofWP_CLI::warning
#15LoggerMapEntry
that simplifies the whole thing significantly due to type safetyLoggerMapEntry
catches almost all cases2.0.0
Questions: