Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen visualization incorrect for image at origin #61

Open
rikvl opened this issue Nov 18, 2021 · 0 comments
Open

Screen visualization incorrect for image at origin #61

rikvl opened this issue Nov 18, 2021 · 0 comments

Comments

@rikvl
Copy link
Collaborator

rikvl commented Nov 18, 2021

In the example examples/two_screens.py, the following cross product doesn't work for the direct-line-of-sight image [the one with pos = (0, 0, 0)].

upos = pos + (ZHAT.cross(unit_vector(pos))

As a result, the line associated with this image is not drawn perpendicular to the screen's normal (line of lensed images).
plot-screens-bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant