Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2017 - fix ic-toggle-button-group props not getting passed down to ic-toggle-buttons #2817

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

2017 - fix ic-toggle-button-group props not getting passed down to ic-toggle-buttons #2817

wants to merge 3 commits into from

Conversation

lz405
Copy link
Contributor

@lz405 lz405 commented Nov 22, 2024 •
edited
Loading

Summary of the changes

  • Add handler to update children based on group prop mutations
  • Modify styling of toggle button groups to more closely match designs

Related issues

#2017
#2803

Checklist

General

  • Changes to docs package checked and committed.
  • All acceptance criteria reviewed and met.

Testing

  • Relevant unit tests and visual regression tests added.
  • Visual testing against Figma component specification completed.
  • Playground stories in React Storybook up to date, with any prop changes and additions addressed.
  • Compare performance of modified components against develop using Performance addon in React Storybook.

Accessibility

  • Accessibility Insights FastPass performed.
  • A11y unit test added and yields no issues.
  • A11y plug-in on Storybook yields no issues.
  • Manual screen reader testing performed using NVDA and VoiceOver.
  • Manual keyboard testing for keyboard controls and logical focus order.
  • Correct roles used and ARIA attributes used correctly where required.
  • Logical heading structure is maintained, and the HTML elements used for headings can be changed to fit within the wider page structure.

Resize/zoom behaviour

  • Page can be zoomed to 400% with no loss of content.
  • Screen magnifier used with no issues.
  • Text resized to 200% with no loss of content.
  • Text spacing increased as per the WCAG 1.4.12 success criterion with no loss of content.

System modes

  • Browser setting 'prefers reduced motion' tested. No animations or motion visible whilst this setting is on.
  • Windows High Contrast mode tested with no loss of content.
  • System light and dark mode tested with no loss of content.
  • Browser support tested (Chrome, Safari, Firefox and Edge).

Testing content extremes

  • Min/max content examples tested with no loss of content or overflow.
  • All prop combinations work without issue.
  • Tested for FOUC (Flash of Unstyled Content) in both SSR (Server-Side Rendering) and SSG (Static Site Generation) settings.
  • Controlled and uncontrolled input components tested.
  • Props/slots can be updated after initial render.

@github-actions GitHub Actions
Copy link
Contributor

View your branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button/web-components
View your React branch deployment here: https://mi6.github.io/ic-ui-kit/branches/2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button/react

@lz405 lz405 force-pushed the 2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button branch from 3ca292b to d759a3e Compare November 22, 2024 14:55
@lz405 lz405 force-pushed the 2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button branch 2 times, most recently from bb5c56e to 88ed20e Compare November 28, 2024 14:05
@github-actions GitHub Actions
Copy link
Contributor

Cypress visual tests failed.
View the image diff here: https://github.com/mi6/ic-ui-kit/tree/gh-pages/branches/2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button/cypress-image-diff-screenshots/diff
View the html report here: https://mi6.github.io/ic-ui-kit/branches/2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button/cypress-image-diff-html-report/cypress-image-diff-html-report.html

lz405 and others added 3 commits December 10, 2024 13:52
@lz405
fix(web-components): fix toggle buttons not inheriting props of paren…
bf8845a 
…t group

fix toggle buttons not inheriting props of parent toggle button group element

fix #2017
@lz405
test(react): regenerate visual regression tests
f02764a 
regenerate visual regression tests

test #2017

feat(react): update Cypress visual regression test baseline images
@github-actions @lz405
feat(react): update Cypress visual regression test baseline images
03a4da8
@lz405 lz405 force-pushed the 2017-ic-toggle-button-group-props-dont-seem-to-be-passed-down-correctly-to-toggle-button branch from 24ac932 to 03a4da8 Compare December 10, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@lz405