Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

comment yaml (+empty lines?) #17

Open
ghost opened this issue Jan 21, 2018 · 4 comments
Open

comment yaml (+empty lines?) #17

ghost opened this issue Jan 21, 2018 · 4 comments

Comments

@ghost
Copy link

ghost commented Jan 21, 2018

# Colors (Dracula)
colors:
  # Default colors
  primary:
    background: '0x282a36'
    foreground: '0xf8f8f2'

gets commented inti

Colors (Dracula)
# colors:
  Default colors
  # primary:
    # background: '0x282a36'
    # foreground: '0xf8f8f2'
# 

rather than expected

# Colors (Dracula)
# colors:
#   # Default colors
#   primary:
#     background: '0x282a36'
#     foreground: '0xf8f8f2'

probably because there is no support for YAML? Shoudn't comment rather not do anything in such a case?

furthermore: is it intended behavior to comment empty lines (eg. .c files)? Seems a bit weird to me.

@sum01
Copy link
Contributor

sum01 commented Feb 2, 2018

@monouser7dig This is fixed in v1.0.6

@zyedidia
Copy link
Member

zyedidia commented Feb 2, 2018

I don't believe this is fixed unfortunately. Are you unable to reproduce?

@sum01
Copy link
Contributor

sum01 commented Feb 2, 2018

Well the empty line no longer gets commented. I guess the comments being uncommented is a bit of an issue still.

@ghost
Copy link
Author

ghost commented Feb 2, 2018

on my side it's just the same as before, running comment 1.0.6, checked by looking at plugin list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants