Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bot should warn developers once when branches do not match convention #22

Open
jack828 opened this issue Sep 30, 2022 · 1 comment
Open

Comments

@jack828
Copy link
Contributor

jack828 commented Sep 30, 2022

If a developer creates a branch that does not start with one of the known conventions e.g. feat/ feature/ fix/ bug/ then when these get merged into releases it creates additional overhead and confusion for PMs releasing the work, as their release commands are ignored.

It would be good if when PRs are created and the various status checks are added, that it could do a quick check of the branch naming and warn the developer (once) that it does not match the naming convention for releases.

e.g.

@jack828 Your branch name starts with `foobar/` which is not one of the supported branch names for the release workflow.
If deployments of this branch are required, please recreate the pull request with one of the following prefixes:
Features - `feature/` or `feat/`
Bugfixes - `fix/` or `bug/`

Related #12

My thoughts above moving this from the release PR comment to the work PR comment is that it is the developer's responsibility to make the branch compatible with releases.

@microadam
Copy link
Owner

Yeah its a good idea, as you can see from #12 its an issue I have known about for some time! Doing it just ONCE might be tricky though, as the app is completely stateless

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants