Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update documentation #8

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

update documentation #8

wants to merge 14 commits into from

Conversation

kaijli
Copy link
Contributor

@kaijli kaijli commented Nov 15, 2024

added image and updated index.rst

@kaijli kaijli requested a review from aclum November 15, 2024 00:26
@kaijli kaijli self-assigned this Nov 15, 2024
@kaijli kaijli linked an issue Nov 15, 2024 that may be closed by this pull request
README.md Outdated
@@ -1,7 +1,8 @@
# The Metatranscriptome Assembly Pipeline

## Summary
This workflow is developed by Brian Foster at JGI. Original repo can be found [here](https://code.jgi.doe.gov/BFoster/jgi_meta_wdl/-/tree/master/metatranscriptome). This workflow uses BBTools and SPAdes to assemble QC'ed transcriptomic reads.
This workflow was developed by Brian Foster at JGI. Original repo can be found (here)[https://code.jgi.doe.gov/BFoster/jgi_meta_wdl/-/tree/master/metatranscriptome]. This workflow uses BBTools and SPAdes to assemble QC'ed transcriptomic reads.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check with Brian F., this is out of date since isn't on spades version 4.

README.md Outdated
@@ -1,7 +1,8 @@
# The Metatranscriptome Assembly Pipeline

## Summary
This workflow is developed by Brian Foster at JGI. Original repo can be found [here](https://code.jgi.doe.gov/BFoster/jgi_meta_wdl/-/tree/master/metatranscriptome). This workflow uses BBTools and SPAdes to assemble QC'ed transcriptomic reads.
This workflow was developed by Brian Foster at JGI. Original repo can be found (here)[https://code.jgi.doe.gov/BFoster/jgi_meta_wdl/-/tree/master/metatranscriptome]. This workflow uses BBTools and SPAdes to assemble QC'ed transcriptomic reads.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here hyperlink format is not correct.

docs/index.rst Show resolved Hide resolved
docs/index.rst Show resolved Hide resolved
docs/index.rst Outdated Show resolved Hide resolved
@kaijli kaijli requested a review from aclum November 22, 2024 00:10
@aclum
Copy link

aclum commented Nov 22, 2024

I was suprised that the end to end workflow doesn't include read qc?

@kaijli
Copy link
Contributor Author

kaijli commented Nov 25, 2024

the scripts that are run are readlength.sh, rnaspades.py, fungalrelease.sh, bbstats.sh, bbmap.sh, samtools index, reformat.sh, pileup.sh, and samtools flagstat. I don't think any of those are read qc tools?

@aclum
Copy link

aclum commented Nov 25, 2024

They aren't but this is an oversight IMO. The end to end metagenome workflow contains a filtering step https://github.com/microbiomedata/metaG/blob/main/nmdc-metag_full.wdl (call rqc.jgi_rqcfilter on line 26). The metaT end to end workflow should mirror this and have a filtering (read qc) step.

@kaijli
Copy link
Contributor Author

kaijli commented Nov 26, 2024

is readsqc not enough to count towards that? this is the assembly ticket?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metaT assembly - Kaitlyn
2 participants