-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update documentation #8
base: main
Are you sure you want to change the base?
Conversation
README.md
Outdated
@@ -1,7 +1,8 @@ | |||
# The Metatranscriptome Assembly Pipeline | |||
|
|||
## Summary | |||
This workflow is developed by Brian Foster at JGI. Original repo can be found [here](https://code.jgi.doe.gov/BFoster/jgi_meta_wdl/-/tree/master/metatranscriptome). This workflow uses BBTools and SPAdes to assemble QC'ed transcriptomic reads. | |||
This workflow was developed by Brian Foster at JGI. Original repo can be found (here)[https://code.jgi.doe.gov/BFoster/jgi_meta_wdl/-/tree/master/metatranscriptome]. This workflow uses BBTools and SPAdes to assemble QC'ed transcriptomic reads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check with Brian F., this is out of date since isn't on spades version 4.
README.md
Outdated
@@ -1,7 +1,8 @@ | |||
# The Metatranscriptome Assembly Pipeline | |||
|
|||
## Summary | |||
This workflow is developed by Brian Foster at JGI. Original repo can be found [here](https://code.jgi.doe.gov/BFoster/jgi_meta_wdl/-/tree/master/metatranscriptome). This workflow uses BBTools and SPAdes to assemble QC'ed transcriptomic reads. | |||
This workflow was developed by Brian Foster at JGI. Original repo can be found (here)[https://code.jgi.doe.gov/BFoster/jgi_meta_wdl/-/tree/master/metatranscriptome]. This workflow uses BBTools and SPAdes to assemble QC'ed transcriptomic reads. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here hyperlink format is not correct.
I was suprised that the end to end workflow doesn't include read qc? |
the scripts that are run are |
They aren't but this is an oversight IMO. The end to end metagenome workflow contains a filtering step https://github.com/microbiomedata/metaG/blob/main/nmdc-metag_full.wdl (call rqc.jgi_rqcfilter on line 26). The metaT end to end workflow should mirror this and have a filtering (read qc) step. |
is readsqc not enough to count towards that? this is the assembly ticket? |
added image and updated index.rst