Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

offline use: MakeCode's normal cacheing behaviour is not preserved in webview #67

Open
jaustin opened this issue May 21, 2024 · 1 comment

Comments

@jaustin
Copy link

jaustin commented May 21, 2024

Describe the bug

When clicking 'create code' while not connected to the internet, even if MakeCode has previously been loaded in the app, does not launch MakeCode.

To Reproduce

  1. Load MakeCode with 'create code'
  2. Use it
  3. Quit the app
  4. Disable connectivity /enable Airplane mode
  5. Open the app and choose "Create code"
  6. 404 page

Expected behavior
We would expect the cached version of MakeCode to load.

@microbit-carlos has debuged this in the desktop browser too - it appears our queryparameter specifying the android app (or the ?dbg=1) appears to defeat the cacheing.

@microbit-matt-hillsdon do you think this is really a MakeCode bug given the issue with the queryparam?

@jaustin
Copy link
Author

jaustin commented May 21, 2024

Using the 'change makecode URL' option (long press on the micro:bit face on homescreen) to remove the queryparameter fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant