From 539ec38489a29a4d335cab6b3f984f3caacff295 Mon Sep 17 00:00:00 2001 From: DaVinci9196 Date: Mon, 18 Nov 2024 15:46:56 +0800 Subject: [PATCH 1/2] Google Maps location information sharing page settings button click no response --- play-services-core/src/main/AndroidManifest.xml | 4 ++++ .../kotlin/org/microg/gms/accountsettings/ui/MainActivity.kt | 3 ++- .../kotlin/org/microg/gms/accountsettings/ui/extensions.kt | 1 + 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/play-services-core/src/main/AndroidManifest.xml b/play-services-core/src/main/AndroidManifest.xml index 0c606960c5..24acdfc209 100644 --- a/play-services-core/src/main/AndroidManifest.xml +++ b/play-services-core/src/main/AndroidManifest.xml @@ -764,6 +764,10 @@ + + + + Date: Sat, 14 Dec 2024 21:10:22 +0100 Subject: [PATCH 2/2] Account Settings: Don't give preference to action over screen id for actions that would just show the main screen --- .../kotlin/org/microg/gms/accountsettings/ui/MainActivity.kt | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/play-services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/MainActivity.kt b/play-services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/MainActivity.kt index 21230008ac..d8c97a9832 100644 --- a/play-services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/MainActivity.kt +++ b/play-services-core/src/main/kotlin/org/microg/gms/accountsettings/ui/MainActivity.kt @@ -118,8 +118,6 @@ private val ALLOWED_WEB_PREFIXES = setOf( ) private val ACTION_TO_SCREEN_ID = hashMapOf( - ACTION_MY_ACCOUNT to 1, - ACTION_ACCOUNT_PREFERENCES_SETTINGS to 1, ACTION_SECURITY_SETTINGS to 10006, ACTION_PRIVACY_SETTINGS to 10004, ACTION_LOCATION_SHARING to 210, @@ -135,7 +133,7 @@ class MainActivity : AppCompatActivity() { Log.d(TAG, "Invoked with ${intent.action} and extras $extras") super.onCreate(savedInstanceState) - val screenId = ACTION_TO_SCREEN_ID[intent.action] ?: intent?.getIntExtra(EXTRA_SCREEN_ID, -1).takeIf { it != -1 } ?: 1 + val screenId = ACTION_TO_SCREEN_ID[intent.action] ?: intent?.getIntExtra(EXTRA_SCREEN_ID, -1)?.takeIf { it > 0 } ?: 1 val product = intent?.getStringExtra(EXTRA_SCREEN_MY_ACTIVITY_PRODUCT) val kidOnboardingParams = intent?.getStringExtra(EXTRA_SCREEN_KID_ONBOARDING_PARAMS)