-
Notifications
You must be signed in to change notification settings - Fork 993
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log delta count in addition to throughput in LoggingMeterRegistry #5590
base: main
Are you sure you want to change the base?
Conversation
micrometer-core/src/main/java/io/micrometer/core/instrument/logging/LoggingMeterRegistry.java
Outdated
Show resolved
Hide resolved
micrometer-core/src/main/java/io/micrometer/core/instrument/logging/LoggingMeterRegistry.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the pull request and quick action on review. This looks good to me. We'll have to wait to merge until we start 1.15 development on main
.
What do you think about calling it |
Thanks for your quick review. I was hoping that this change could still be part of 1.14.0 GA. |
I woud keep delta_count in the logs. |
Our general policy is that we do not merge enhancements after a release candidate is released. 1.14.0-RC1 was released yesterday, so the next opportunity for enhancements is 1.15.0-M1. |
I've noticed a discrepancy in logs for counters between delta_count and throughput when baseUnit is set. |
OK, clear. Do you already have an estimation of release date for 1.15.0 GA ? |
We have a 6 months minor release cycle, based on our current release schedule, |
I've gone ahead and added tentative dates for 1.15 to our support page: https://micrometer.io/support/ |
Closes #5548