Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Micronaut CRaC JDBC Guide #1379

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Micronaut CRaC JDBC Guide #1379

wants to merge 2 commits into from

Conversation

sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Nov 22, 2023

No description provided.

@sdelamo sdelamo requested a review from timyates November 22, 2023 12:12
@timyates
Copy link
Contributor

The maven guide seems to hang for me... investigating

@timyates
Copy link
Contributor

I think there's something odd going on in the maven test... Sometimes it passes, sometimes it fails, and sometimes it hangs...

And I cannot think why

@sdelamo
Copy link
Contributor Author

sdelamo commented Nov 22, 2023

I think there's something odd going on in the maven test... Sometimes it passes, sometimes it fails, and sometimes it hangs...

And I cannot think why

should we remove maven for now?

@timyates
Copy link
Contributor

I'm not sure if it's just maven... 🤔

timyates
timyates suggested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong here. Both Maven and Gradle are sometimes hanging when the tests are executed multiple times...

As far as I can tell, it gets down to calling server.start() in the CRaC NettyEmbeddedServerResource, but then it never comes back.

I tried with both TestResources and TestContainers. Something must have changed in netty that's causing the hanging...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timyates timyates timyates requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sdelamo @timyates