Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to use this depenedency with JPMS #289

Closed
m4ttek opened this issue Jul 18, 2023 · 3 comments
Closed

Unable to use this depenedency with JPMS #289

m4ttek opened this issue Jul 18, 2023 · 3 comments
Labels
status: awaiting third-party Awaiting changes to a third party library status: next major version The issue will be considered for the next major version

Comments

@m4ttek
Copy link

m4ttek commented Jul 18, 2023 •
edited
Loading

Expected Behavior

Micronaut application should work with JPMS based application but it is not possible with this module due to problematic transitive dependency zalando-problem.

Actual Behaviour

The same problem as mine is reported in zalando/problem#357 and it has not been fixed since 2022.

Steps To Reproduce

No response

Environment Information

  • JDK 20 with module-info defined

Example Application

No response

Version

3.0.1 used with micronaut 4.0.0
@sdelamo sdelamo assigned sdelamo and unassigned sdelamo Jul 19, 2023
@sdelamo
Copy link
Contributor

sdelamo commented Jul 19, 2023

I don't think we can fix it here. It has to be fixed in zalando/problem.

@sdelamo sdelamo added the status: awaiting third-party Awaiting changes to a third party library label Jul 19, 2023
@timyates timyates moved this to In Progress in 4.0.4 Release Aug 7, 2023
@timyates timyates moved this from In Progress to Todo in 4.0.4 Release Aug 7, 2023
@timyates
Copy link
Contributor

So, as mentioned in the issue, this is a problem with zalando/problem#357

There's a wider discussion around Micronaut and JPMS going on as well

micronaut-projects/micronaut-core#6395

Which has been currently scheduled for Micronaut 5 (as it would be a breaking change)

Unfortunately I think we need both of these pieces for this to work. So I'm moving this to Micronaut 5 and hoping the zalando issue is fixed by then 🤞

@timyates timyates removed this from 4.0.4 Release Aug 16, 2023
@timyates timyates added the status: next major version The issue will be considered for the next major version label Aug 16, 2023
@m4ttek
Copy link
Author

m4ttek commented Aug 16, 2023

It seems that changes proposed in this PR zalando/problem#483 will fix it.

@sdelamo sdelamo removed this from 5.0.0 Release Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: awaiting third-party Awaiting changes to a third party library status: next major version The issue will be considered for the next major version
Projects
6.0.0 Release
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@timyates @graemerocher @sdelamo @m4ttek