Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Making the HttpSessionFilter pattern configurable #206

Open
wants to merge 12 commits into
base: 4.6.x
Choose a base branch
from
Open

Making the HttpSessionFilter pattern configurable #206

wants to merge 12 commits into from

Conversation

ChaimaaeROUAI
Copy link
Contributor

@ChaimaaeROUAI ChaimaaeROUAI commented Nov 4, 2024 •
edited by sdelamo
Loading

This PR makes the HttpSessionFilter pattern configurable. It also adds a property to disable the filter.

Close: #171

@ChaimaaeROUAI ChaimaaeROUAI added the type: improvement A minor improvement to an existing feature label Nov 4, 2024
@ChaimaaeROUAI ChaimaaeROUAI requested a review from sdelamo November 4, 2024 14:37
sdelamo
sdelamo requested changes Nov 4, 2024
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It misses tests

sdelamo
sdelamo requested changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@sdelamo sdelamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test with verifies that you can configure certain paths to be excluded by the filter?

@sdelamo sdelamo changed the base branch from 4.5.x to 4.6.x December 11, 2024 09:37
@sdelamo sdelamo requested a review from yawkat December 11, 2024 10:27
@sdelamo sdelamo linked an issue Dec 11, 2024 that may be closed by this pull request
Session fetched for static assets #171
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 11, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
55.6% Coverage on New Code (required ≥ 70%)

See analysis details on SonarQube Cloud

@sdelamo
Copy link
Contributor

sdelamo commented Dec 11, 2024

sonar code coverage is incorrect. The PR includes tests which set enabled to false and the regex-pattern

@sdelamo sdelamo changed the title Makingthe HttpSessionFilter pattern configurable Making the HttpSessionFilter pattern configurable Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdelamo sdelamo sdelamo requested changes

@yawkat yawkat Awaiting requested review from yawkat

Assignees
No one assigned
Labels
type: improvement A minor improvement to an existing feature
Projects
4.8.0 Release
Status: Ready for Review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Session fetched for static assets
2 participants
@ChaimaaeROUAI @sdelamo