Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Couchbase support #388

Open
CezaryBD opened this issue Aug 30, 2023 · 5 comments
Open

Couchbase support #388

CezaryBD opened this issue Aug 30, 2023 · 5 comments

Comments

@CezaryBD
Copy link

Feature description

Hello Team,

I would like to ask for an implementation towards enabling Couchbase support with Micronaut Framework.
I have found that such a thing existed in the past, so maybe it would be feasible to revive it.

Please provide me an information if such a feature is currently possible to be implemented.
If not: is there a possibility to have test-resources support for Couchbase from Micronaut Framework?

Thank you!

@dstepanov
Copy link

For the test resources please create an issue here https://github.com/micronaut-projects/micronaut-test-resources

@dstepanov dstepanov transferred this issue from micronaut-projects/micronaut-data Sep 8, 2023
@melix
Copy link
Collaborator

melix commented Sep 8, 2023

It is certainly possible to have Couchbase support in test resources. One step towards this would be to revive https://github.com/micronaut-projects/micronaut-couchbase which was archived, AFAIK, because no-one in the community took the lead. Maybe you'd be interested?

As for test resources, I see it as the 2d step. First we need the "official" Couchbase support, then we can implement a dedicated test resources provider. In the meantime, using the generic test resources container support should be enough.

@dstepanov
Copy link

I think we can support it without proper support from Micronaut.
Maybe a simple couchbase.uri or something can just start the container, possibly we can hide it under testresources.couchbase prefix.

@melix
Copy link
Collaborator

melix commented Sep 8, 2023

I am not convinced that adding support for "random" properties is a good idea, as we effectively don't know where and why they are used, which would give test resources "precedence" and somehow would need to provide guidance. Instead we already have support for arbitrary containers via the generic test containers support, and possibly even custom providers if needed.

@dstepanov
Copy link

Test containers add a lot of value https://github.com/testcontainers/testcontainers-java/blob/main/modules/couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseContainer.java which users are going to miss with a generic approach. It might be more complicated to detect startup etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants