Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adaptive Sampling Default SetLastObservedSamplingPercentage #2914

Open
czb182 opened this issue Nov 8, 2024 · 0 comments
Open

Adaptive Sampling Default SetLastObservedSamplingPercentage #2914

czb182 opened this issue Nov 8, 2024 · 0 comments

Comments

@czb182
Copy link

czb182 commented Nov 8, 2024

Why is SetLastObservedSamplingPercentage only called for Request type telemetry by default?

I'm customized adaptive sampling, so I have disabled in config and setting up in code per this documentation
https://learn.microsoft.com/en-us/azure/azure-monitor/app/sampling-classic-api#configure-sampling-settings

I was taking the default setup from this repo to build upon it.

Notice that the default adaptive sampling uses a sampling callback to setup lastobserved for request telemetry

configuration.SetLastObservedSamplingPercentage(SamplingTelemetryItemTypes.Request, newPercentage);

this is not shown in documentation, and I gather its to increase accuracy of sampling, but why not set last observed for all types included in sampling?

Not sure if this is issue or not. Or maybe because sampling seems to be done at the operation level (seemingly) you only need to set for one type?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant