Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to add interface for constuctors to add static properites #1379

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Spice-King
Copy link

OK, this PR is a headache and a trip down the rabbit hole for me. It's technically a broken PR as I know one test fails, but I can't fix it without input on how.

Long story short, I'm working with a team to develop a types package for a framework (I guess that's the best way to put it, Foundry VTT for the interested), and in there they patch in a number of static and instance methods to built in objects (not ideal, but we have don't have control on this).

This was fine for most things to add static methods to things like Array and Number which had ArrayConstructor and NumberConstructor as ways to extend the constructor's types. Totally fine, up to this point. Then they added a static method for URL and URLConstructor does not exist. My temp fix locally was to manually redefine the URL variable instance since it's a type rather than an interface and slap a @ts-expect-error comment on it for now, but I figured this is something that could be fixed up stream and give everything I can a constructor interface.

Good news, I did that, works just fine for almost everything. Bad news, broke a single test because of a snowflake. So much for a simple PR to make things better. My simple patch does generate for URL (and others) the same style of constructor interface for type merging, worked for all but AudioWorkletProcessor, as it already has AudioWorkletProcessorConstructor defined.

unittests/files/audioworklet/usage.ts:3:17 - error TS2510: Base constructors must all have the same return type.

3   class extends AudioWorkletProcessor {
                  ~~~~~~~~~~~~~~~~~~~~~


Found 1 error in unittests/files/audioworklet/usage.ts:3

Now the "offending" bit is defined here

"AudioWorkletProcessorConstructor": {
"overrideSignatures": [
"new (options: any): AudioWorkletProcessorImpl"
]
}
. This starts to open a larger can of worms than I can reasonably try to keep a lid on. Reading this at least fills me in on why AudioWorkletProcessorImpl exists to deal with the process method.

I leave this here in a vague hope that my last 4 hours of head scratching, poking, and prodding to find out why URLConstructor did not exist while trying to add it in helps somewhat.

@ghost
Copy link

ghost commented Aug 14, 2022

CLA assistant check
All CLA requirements met.

@github-actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant