Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(docs): rectify typos and spelling mistakes #1632

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

adeyinkaezra123
Copy link

Created a fresh branch to clean up the commit tree

@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

Thanks for the PR!

This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged.

Copy link
Contributor

@saschanaz saschanaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typos seem all fixed in upstream too. One nit:

@@ -68,7 +68,7 @@
"DedicatedWorkerGlobalScope": "The DedicatedWorkerGlobalScope object (the Worker global scope) is accessible through the self keyword. Some additional global functions, namespaces objects, and constructors, not typically associated with the worker global scope, but available on it, are listed in the JavaScript Reference. See also: Functions available to workers.",
"DelayNode": "The DelayNode interface represents a delay-line; an AudioNode audio-processing module that causes a delay between the arrival of an input data and its propagation to the output.",
"DeviceAcceleration": "A DeviceAcceleration object provides information about the amount of acceleration the device is experiencing along all three axes.",
"DeviceLightEvent": "The DeviceLightEvent provides web developers with information from photo sensors or similiar detectors about ambient light levels near the device. For example this may be useful to adjust the screen's brightness based on the current ambient light level in order to save energy or provide better readability.",
"DeviceLightEvent": "The DeviceLightEvent provides web developers with information from photo sensors or similar detectors about ambient light levels near the device. For example this may be useful to adjust the screen's brightness based on the current ambient light level in order to save energy or provide better readability.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this one can be fully removed, MDN doesn't have it anymore and lib.d.ts doesn't have it either.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay

@saschanaz
Copy link
Contributor

You need to rebuild, btw.

@adeyinkaezra123
Copy link
Author

You need to rebuild, btw.

How do I do that?

@saschanaz
Copy link
Contributor

saschanaz commented Oct 9, 2023

See: https://github.com/microsoft/TypeScript-DOM-lib-generator#build-instructions (npm run build && npm run baseline-accept)

@adeyinkaezra123
Copy link
Author

Done!

@saschanaz
Copy link
Contributor

That went wrong, can you either rebase your commit on top of the current main branch or run npm i && npm run build && npm run baseline-accept instead?

@adeyinkaezra123
Copy link
Author

Done 💯

@adeyinkaezra123
Copy link
Author

Any update concerning this @saschanaz ?

@saschanaz
Copy link
Contributor

This still looks wrong, can you rebase and then run npm i && npm run build && npm run baseline-accept ? This PR should not add any new members.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants