feat: add type parameter to EventTarget #1712
Open
+108
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a type parameter to
EventTarget
such that the following is now possible:Defaults to
T = any
to maintain existing behaviour otherwise.Reviewer notes
i did two attempts at this:
EventTarget
where it will then emit event handlers1 - overrides (this PR)
i don't like that i'm basically repeating the signatures of
emitEventHandlers
manually in the overrides JSON. though the result does seem to work well.maybe there's a cleaner way to do this?
2 - update the emitter
we could just change
emitEventHandlers
to ultimately do this logic:which is then used to print the signatures.
i've tried this and it failed because it adds those signatures rather than replacing the existing ones.
any advice would be helpful of how to approach this
also if there's some fundamental reason this can never work, im of course happy to close the PR but would like to understand first