Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cloneNode Return Type Must Be Active Class, Not Base Class (Node) #1723

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

cloneNode Return Type Must Be Active Class, Not Base Class (Node) #1723

wants to merge 1 commit into from

Commits on May 12, 2024

  1. cloneNode returns this (not Node) 

    The `cloneNode` return type is incorrect. The type before this change indicated that `cloneNode` returned a `Node`, which then broke any class that extended `Node`. In reality, `cloneNode` will return an instance of whatever the current class type is, a.k.a. `this` (`DocumentFragment#cloneNode` returns a `DocumentFragment`, not a `Node`).
    @andria-dev
    andria-dev committed May 12, 2024
    Configuration menu
    Copy the full SHA
    0ed2641 View commit details
    Browse the repository at this point in the history