-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add /** @deferred */ comments to deferred callback parameters #1757
base: main
Are you sure you want to change the base?
Conversation
Thanks for the PR! This section of the codebase is owned by @saschanaz - if they write a comment saying "LGTM" then it will be merged. |
You also need to |
(Looks good. feel free to merge when the TS PR is ready) |
|
And another question, is it the requirement here for the callback to be called asynchronously? What happens if those callbacks can be called both sync/async? |
The BTW, I haven't been able to find any authoritative documentation on sync vs. async for the various DOM callbacks, so it could well be that some of the modifiers shouldn't be present. |
This PR adds
/** @deferred */
comments to deferred callback parameters in preparation for microsoft/TypeScript#58729.