Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added strict typings for ARIAMixin with literals #1840

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Added strict typings for ARIAMixin with literals #1840

wants to merge 5 commits into from

Commits on Nov 3, 2024

  1. feat(ARIAMixin): Add strict typings for ARIA properties with literals

    @DeepDoge
    DeepDoge committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    b217306 View commit details
    Browse the repository at this point in the history

  2. fix(ARIAMixin): Removed string literal types for ariaBrailleLabel a… 

    …nd `ariaBrailleRoleDescription`
    @DeepDoge
    DeepDoge committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    807b62b View commit details
    Browse the repository at this point in the history

  3. fix(ARIAMixin): Added string literal types for ariaRequired

    @DeepDoge
    DeepDoge committed Nov 3, 2024
    Configuration menu
    Copy the full SHA
    acdd5ab View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. fix(ARIAMixin): Improve type definitions and enums 

    - Remove commented items
- Remove `string & {}` from types
- Remove empty strings from number types
- Update and export roles as enum `ARIARole`
- Add type for `ariaInvalid`
- Add unit tests
    @DeepDoge
    DeepDoge committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    c6faa1c View commit details
    Browse the repository at this point in the history

  2. fix(ARIAMixin): Add unit test for role

    @DeepDoge
    DeepDoge committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b52decf View commit details
    Browse the repository at this point in the history