Migrate latest dom types into libdom.d.ts #44684

orta · 2021-06-21T13:13:58Z

Re: #44424 and microsoft/TypeScript-DOM-lib-generator#1023

types-web is the very actively maintained version of lib dom, most likely the version which we'd be basing @types/web on. It's quite far ahead of the current TS .d.ts.

Note that there are new failures from this, I think due to the addition of readonly attributes

    tests/baselines/reference/mappedTypeRecursiveInference.errors.txt
    tests/baselines/reference/varianceCallbacksAndIndexedAccesses.errors.txt

orta · 2021-06-21T13:14:59Z

@typescript-bot test this
@typescript-bot run dt

typescript-bot · 2021-06-21T13:15:04Z

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at ea65c43. You can monitor the build here.

typescript-bot · 2021-06-21T13:15:04Z

Heya @orta, I've started to run the extended test suite on this PR at ea65c43. You can monitor the build here.

orta · 2021-06-21T14:55:02Z

Some notes as I go through the fails

console.exception is deprecated, basically is an alias to error, which is fine
somehow JSX is getting defined?
We probably need an alias for EventListenerOrEventListenerObject - as that has been recommended for a long time as the way to add typing to events

sandersn · 2021-06-21T17:30:10Z

Additional notes:

Looks like there might be a bug in reverse mapped types, perhaps to do with readonly. We'll need to file a bug and work around it.
The JSX failures are from our old mock version of react@16. It has 13 new errors, but I don't yet know what they are.

orta · 2021-06-22T17:51:02Z

Looking at the DT results, I think we'll need to:

Get EventListenerOrEventListenerObject back in the dom.d.ts because people extend it (for example angular)
EventListener needs to not be a union
Revert the readonly prototypes change (lots of assignability issues in DT)
Bring back HTMLTableDataCellElement, HTMLTableHeaderCellElement , StyleMedia and ClientRect because React uses
Maybe bring back HTMLDocument
Not sure what to do with: Interface 'Navigator' incorrectly extends interface 'NavigatorNetworkInformation'.

Maybe OffscreenCanvas needs to come back?

orta · 2021-06-24T14:08:52Z

This has all of:

Changed in it - still not enough to not get weird JSX issues in the compiler tests, but at least we can see how different it is with DT

@typescript-bot test this
@typescript-bot run dt

typescript-bot · 2021-06-24T14:08:55Z

Heya @orta, I've started to run the extended test suite on this PR at d4afc2e. You can monitor the build here.

typescript-bot · 2021-06-24T14:08:55Z

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at d4afc2e. You can monitor the build here.

orta · 2021-06-24T16:37:11Z

Upstream dom.d.ts changes:

We need to add: interface HTMLDialogElement extends HTMLElement {} ( preact and react) which will get TS' test suite green
OffscreenCanvas should get addded
HTMLDocument - we should add this
~~getUserMedia should come back~~

Changes to DT:

applicationCache for jquerymobile
Bunch of pkijs fails for Key params
DocumentEvent for tinymce

Something is up with

Error in polymer
Error: Errors in typescript@local for external dependencies:
../webcomponents.js/index.d.ts(68,9): error TS2687: All declarations of 'customElements' must have identical modifiers.
../../../../../../built/local/lib.dom.d.ts(17160,14): error TS2687: All declarations of 'customElements' must have identical modifiers.

w3c-css-typed-object-model-level-1 - getMatchedCSSRules was removed
Firefox depended on DOMError, can look to see if that's a change upstream probably change

Rest of the tests

TS 4.4's version of the DOM deprecates some more elements. Remove them from blissfuljs as well. microsoft/TypeScript#44684

sandersn · 2021-06-24T18:29:49Z

From DT fixes:

SVGCircleElement is now assignable to SVGPathElement because it's a subtype, because SVGPathElement dropped all its non-add/removeEventListener properties. Need to decide if Path should have some artificial property to distinguish it from other SVGGeometryElement subtypes. (from d3-shape/v1)
preact uses HTMLDialogElement and will need a PR in order for dependents to use TS 4.4.
cordova-plugin-file vendored filesystem/index.d.ts from DT and also needs to be updated. @types/ng-cordova depends on it.

TS 4.4's version of the DOM deprecates some more elements. Remove them from blissfuljs as well. microsoft/TypeScript#44684

orta · 2021-06-24T18:46:47Z

Decided against adding navigator.getUserMedia it just needs switching in DT tests to navigator.mediaDevices.getUserMedia

orta · 2021-06-24T19:04:37Z

@typescript-bot test this
@typescript-bot run dt

typescript-bot · 2021-06-24T19:04:40Z

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at 429c877. You can monitor the build here.

typescript-bot · 2021-06-24T19:04:40Z

Heya @orta, I've started to run the extended test suite on this PR at 429c877. You can monitor the build here.

It refers to DOMError, which is no longer declared in TS 4.4's version of the DOM. microsoft/TypeScript#44684

Discovered while upgrading to TS 4.4's DOM. microsoft/TypeScript#44684

orta · 2021-06-26T06:27:17Z

@typescript-bot run dt - <edit/> looks like this won't run after the merge

typescript-bot · 2021-06-26T06:27:32Z

Heya @orta, I've started to run the parallelized Definitely Typed test suite on this PR at fbce8ed. You can monitor the build here.

TS 4.4 further changes webrtc types. This PR makes it match those upcoming types, commenting out types that conflict between 4.4 and earlier versions of TS. Needed after microsoft/TypeScript#44684 is merged.

TS 4.4 changes mediacapture-record types. This PR makes it match those upcoming types. Needed after microsoft/TypeScript#44684 is merged.

* Make webcomponents.js work with TS 4.4 DOM TS 4.4 improves its types for web components. This PR makes DT match those upcoming types. Needed after microsoft/TypeScript#44684 is merged. * specify minimum ts version * Update minimum TS version of polymer too

* Make wicg-mediasessions work with TS 4.4 DOM TS 4.4 improves its types for MediaSesssion. This PR makes DT match those upcoming types. Needed after microsoft/TypeScript#44684 is merged. * Fix tests

* Make requestidlecallback work with TS 4.4 DOM TS 4.4 improves its types for requestidlecallback. This PR makes DT match those upcoming types. Needed after microsoft/TypeScript#44684 is merged. * remove redundant undefined for now

…4684 (#54090)

fljot · 2021-08-03T15:29:52Z

tests/baselines/reference/truthinessCallExpressionCoercion2.types

@@ -129,7 +129,7 @@ function test(required1: () => boolean, required2: () => boolean, b: boolean, op
 >f.apply : (this: Function, thisArg: any, argArray?: any) => any
 >f : () => void
 >apply : (this: Function, thisArg: any, argArray?: any) => any
->parent : Window
+>parent : Window | null


@orta should we really expect null there?
https://developer.mozilla.org/en-US/docs/Web/API/Window/parent#specifications
https://html.spec.whatwg.org/multipage/browsers.html#dom-parent-dev

* for visibility

It was actually legit comment :) -> microsoft/TypeScript-DOM-lib-generator#1089
thank you @orta @saschanaz

buschtoens · 2021-08-30T17:05:04Z

src/lib/dom.generated.d.ts

-interface SVGElementInstance extends EventTarget {
-    readonly correspondingElement: SVGElement;
-    readonly correspondingUseElement: SVGUseElement;
-}


These properties used to be available on SVGElement, which used to extend SVGElementInstance in LOC 12883. They disappeared during the upgrade from v4.3.5 to v4.4.2.

Reported here: microsoft/TypeScript-DOM-lib-generator#1023 (comment)

Removal was intentional, as per microsoft/TypeScript-DOM-lib-generator#1023 (comment):

Those are not available on any modern browser nor MDN, and thus are probably IE-specific properties. The removal is intended since the types library intends to only include things that exist in modern browsers.

Add the types_web dom dts

ea65c43

typescript-bot assigned orta Jun 21, 2021

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jun 21, 2021

Update

d4afc2e

This was referenced Jun 24, 2021

Make css-font-loading-module match TS 4.4's DOM DefinitelyTyped/DefinitelyTyped#54042

Merged

Make blissfuljs match TS 4.4 DOM DefinitelyTyped/DefinitelyTyped#54043

Merged

sandersn added a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Jun 24, 2021

Make blissfuljs make TS 4.4 DOM

cb988d8

TS 4.4's version of the DOM deprecates some more elements. Remove them from blissfuljs as well. microsoft/TypeScript#44684

sandersn added a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Jun 24, 2021

Make blissfuljs make TS 4.4 DOM (#54043)

ed927b9

TS 4.4's version of the DOM deprecates some more elements. Remove them from blissfuljs as well. microsoft/TypeScript#44684

sandersn mentioned this pull request Jun 24, 2021

Make filesystem work with TS 4.4 DOM DefinitelyTyped/DefinitelyTyped#54046

Merged

Adds new DTS

429c877

Update baselines

fbce8ed

sandersn added a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Jun 24, 2021

Make firefox work with TS 4.4 DOM

258f02f

It refers to DOMError, which is no longer declared in TS 4.4's version of the DOM. microsoft/TypeScript#44684

sandersn mentioned this pull request Jun 24, 2021

Make firefox work with TS 4.4 DOM DefinitelyTyped/DefinitelyTyped#54050

Merged

sandersn added a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Jun 24, 2021

Make guacamole-client work with TS 4.4 DOM

b3a1b31

It refers to DOMError, which is no longer declared in TS 4.4's version of the DOM. microsoft/TypeScript#44684

sandersn mentioned this pull request Jun 25, 2021

Check for parent === null in jquery.postmessage tests DefinitelyTyped/DefinitelyTyped#54097

Merged

sandersn added a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Jun 25, 2021

Check for parent === null in jquery.postmessage tests (#54097)

5eef325

Discovered while upgrading to TS 4.4's DOM. microsoft/TypeScript#44684

RyanCavanaugh approved these changes Jun 25, 2021

View reviewed changes

sandersn merged commit 9ebe11c into microsoft:main Jun 25, 2021

orta added a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Jun 25, 2021

Ensures webxr compiles with TS 4.4 - microsoft/TypeScript#44684 (#54088)

2563cec

Methuselah96 mentioned this pull request Jun 27, 2021

[d3-shape] Fix build DefinitelyTyped/DefinitelyTyped#54128

Merged

8 tasks

sandersn pushed a commit to DefinitelyTyped/DefinitelyTyped that referenced this pull request Jun 29, 2021

Ensures playerframework compiles with TS 4.4 - microsoft/TypeScript#4…

ed86bdc

…4684 (#54090)

fljot reviewed Aug 3, 2021

View reviewed changes

orta mentioned this pull request Aug 3, 2021

Removes the nullable attribute from window.parent microsoft/TypeScript-DOM-lib-generator#1089

Merged

buschtoens reviewed Aug 30, 2021

View reviewed changes

etimberg mentioned this pull request Sep 2, 2021

errors with typescript 4.4 chartjs/Chart.js#9594

Closed

This was referenced Oct 27, 2021

aria properties can no longer be undefined in TypeScript 4.4+ #46554

Closed

ionicons errors on typescript >= 4.4.x ionic-team/ionicons#1011

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate latest dom types into libdom.d.ts #44684

Migrate latest dom types into libdom.d.ts #44684

orta commented Jun 21, 2021 •

edited

Loading

orta commented Jun 21, 2021

typescript-bot commented Jun 21, 2021 •

edited

Loading

typescript-bot commented Jun 21, 2021 •

edited

Loading

orta commented Jun 21, 2021 •

edited

Loading

sandersn commented Jun 21, 2021

orta commented Jun 22, 2021 •

edited

Loading

orta commented Jun 24, 2021

typescript-bot commented Jun 24, 2021 •

edited

Loading

typescript-bot commented Jun 24, 2021 •

edited

Loading

orta commented Jun 24, 2021 •

edited

Loading

sandersn commented Jun 24, 2021 •

edited

Loading

orta commented Jun 24, 2021

orta commented Jun 24, 2021

typescript-bot commented Jun 24, 2021 •

edited

Loading

typescript-bot commented Jun 24, 2021 •

edited

Loading

orta commented Jun 26, 2021 •

edited

Loading

typescript-bot commented Jun 26, 2021 •

edited

Loading

fljot Aug 3, 2021

fljot Sep 6, 2021

buschtoens Aug 30, 2021 •

edited

Loading

buschtoens Aug 30, 2021

Migrate latest dom types into libdom.d.ts #44684

Migrate latest dom types into libdom.d.ts #44684

Conversation

orta commented Jun 21, 2021 • edited Loading

orta commented Jun 21, 2021

typescript-bot commented Jun 21, 2021 • edited Loading

typescript-bot commented Jun 21, 2021 • edited Loading

orta commented Jun 21, 2021 • edited Loading

sandersn commented Jun 21, 2021

orta commented Jun 22, 2021 • edited Loading

orta commented Jun 24, 2021

typescript-bot commented Jun 24, 2021 • edited Loading

typescript-bot commented Jun 24, 2021 • edited Loading

orta commented Jun 24, 2021 • edited Loading

sandersn commented Jun 24, 2021 • edited Loading

orta commented Jun 24, 2021

orta commented Jun 24, 2021

typescript-bot commented Jun 24, 2021 • edited Loading

typescript-bot commented Jun 24, 2021 • edited Loading

orta commented Jun 26, 2021 • edited Loading

typescript-bot commented Jun 26, 2021 • edited Loading

fljot Aug 3, 2021

Choose a reason for hiding this comment

fljot Sep 6, 2021

Choose a reason for hiding this comment

buschtoens Aug 30, 2021 • edited Loading

Choose a reason for hiding this comment

buschtoens Aug 30, 2021

Choose a reason for hiding this comment

orta commented Jun 21, 2021 •

edited

Loading

typescript-bot commented Jun 21, 2021 •

edited

Loading

typescript-bot commented Jun 21, 2021 •

edited

Loading

orta commented Jun 21, 2021 •

edited

Loading

orta commented Jun 22, 2021 •

edited

Loading

typescript-bot commented Jun 24, 2021 •

edited

Loading

typescript-bot commented Jun 24, 2021 •

edited

Loading

orta commented Jun 24, 2021 •

edited

Loading

sandersn commented Jun 24, 2021 •

edited

Loading

typescript-bot commented Jun 24, 2021 •

edited

Loading

typescript-bot commented Jun 24, 2021 •

edited

Loading

orta commented Jun 26, 2021 •

edited

Loading

typescript-bot commented Jun 26, 2021 •

edited

Loading

buschtoens Aug 30, 2021 •

edited

Loading