Test generic DOM events again #57040

sandersn · 2024-01-12T15:02:11Z

Test microsoft/TypeScript-DOM-lib-generator#1624

sandersn · 2024-01-12T15:02:22Z

@typescript-bot test top100
@typescript-bot user test this
@typescript-bot run dt
@typescript-bot perf test this
@typescript-bot pack this

typescript-bot · 2024-01-12T15:02:25Z

Heya @sandersn, I've started to run the regular perf test suite on this PR at 682ca9a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-12T15:02:25Z

Heya @sandersn, I've started to run the tarball bundle task on this PR at 682ca9a. You can monitor the build here.

typescript-bot · 2024-01-12T15:02:25Z

Heya @sandersn, I've started to run the diff-based user code test suite on this PR at 682ca9a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-12T15:02:25Z

Heya @sandersn, I've started to run the diff-based top-repos suite on this PR at 682ca9a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-12T15:02:25Z

Heya @sandersn, I've started to run the parallelized Definitely Typed test suite on this PR at 682ca9a. You can monitor the build here.

Update: The results are in!

typescript-bot · 2024-01-12T15:04:20Z

Hey @sandersn, I've packed this into an installable tgz. You can install it for testing by referencing it in your package.json like so:

{
    "devDependencies": {
        "typescript": "https://typescript.visualstudio.com/cf7ac146-d525-443c-b23c-0d58337efebc/_apis/build/builds/159486/artifacts?artifactName=tgz&fileId=85F06FC6ADC4052BA56A5C94C26EECE8187329A1946E1FA8647D86796D0212B102&fileName=/typescript-5.4.0-insiders.20240112.tgz"
    }
}

and then running npm install.

There is also a playground for this build and an npm module you can use via "typescript": "npm:@typescript-deploys/[email protected]".;

typescript-bot · 2024-01-12T15:20:43Z

@sandersn Here are the results of running the user test suite comparing main and refs/pull/57040/merge:

There were infrastructure failures potentially unrelated to your change:

1 instance of "Package install failed"

Otherwise...

Something interesting changed - please have a look.

Details

bluebird

/mnt/ts_downloads/bluebird/tsconfig.json

[NEW] error TS2403: Subsequent variable declarations must have the same type. Variable 'event' must be of type 'CustomEvent<any>', but here has type 'Event<EventTarget>'.
- /mnt/ts_downloads/bluebird/node_modules/bluebird/js/release/debuggability.js(225,17)
[NEW] error TS2339: Property 'detail' does not exist on type 'Event<EventTarget>'.
- /mnt/ts_downloads/bluebird/node_modules/bluebird/js/release/debuggability.js(232,26)
[MISSING] error TS2403: Subsequent variable declarations must have the same type. Variable 'event' must be of type 'CustomEvent<any>', but here has type 'Event'.
- /mnt/ts_downloads/bluebird/node_modules/bluebird/js/release/debuggability.js(225,17)
[MISSING] error TS2339: Property 'detail' does not exist on type 'Event'.
- /mnt/ts_downloads/bluebird/node_modules/bluebird/js/release/debuggability.js(232,26)

puppeteer

packages/browsers/test/src/tsconfig.json

[MISSING] error TS2307: Cannot find module '@pptr/testserver' or its corresponding type declarations.
- packages/browsers/test/src/utils.ts#L13 in packages/browsers/test/src/tsconfig.json

typescript-bot · 2024-01-12T15:23:11Z

@sandersn
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Angular - node (v18.15.0, x64)}
_{Memory used}	_{295,497k (± 0.01%)}	_{305,098k (± 0.01%)}	_{+9,601k (+ 3.25%)}	_305,060k	_305,126k	_{p=0.005 n=6}
_{Parse Time}	_{2.65s (± 0.28%)}	_{2.66s (± 0.66%)}	_~	_2.63s	_2.68s	_{p=0.864 n=6}
_{Bind Time}	_{0.82s (± 0.00%)}	_{0.82s (± 0.00%)}	_~	_0.82s	_0.82s	_{p=1.000 n=6}
_{Check Time}	_{8.14s (± 0.31%)}	_{8.35s (± 0.31%)}	_{+0.21s (+ 2.60%)}	_8.32s	_8.38s	_{p=0.005 n=6}
_{Emit Time}	_{7.11s (± 0.46%)}	_{7.12s (± 0.52%)}	_~	_7.06s	_7.17s	_{p=0.686 n=6}
_{Total Time}	_{18.72s (± 0.25%)}	_{18.94s (± 0.16%)}	_{+0.22s (+ 1.19%)}	_18.89s	_18.97s	_{p=0.005 n=6}
_{Compiler-Unions - node (v18.15.0, x64)}
_{Memory used}	_{191,975k (± 0.55%)}	_{192,500k (± 1.24%)}	_~	_191,509k	_197,362k	_{p=0.574 n=6}
_{Parse Time}	_{1.36s (± 1.00%)}	_{1.35s (± 1.19%)}	_~	_1.33s	_1.37s	_{p=0.154 n=6}
_{Bind Time}	_{0.72s (± 0.00%)}	_{0.72s (± 0.00%)}	_~	_0.72s	_0.72s	_{p=1.000 n=6}
_{Check Time}	_{9.33s (± 0.38%)}	_{9.37s (± 0.20%)}	_~	_9.35s	_9.39s	_{p=0.061 n=6}
_{Emit Time}	_{2.63s (± 0.50%)}	_{2.63s (± 0.76%)}	_~	_2.61s	_2.66s	_{p=0.797 n=6}
_{Total Time}	_{14.05s (± 0.24%)}	_{14.07s (± 0.23%)}	_~	_14.03s	_14.12s	_{p=0.335 n=6}
_{Monaco - node (v18.15.0, x64)}
_{Memory used}	_{347,403k (± 0.01%)}	_{347,406k (± 0.01%)}	_~	_347,382k	_347,430k	_{p=1.000 n=6}
_{Parse Time}	_{2.47s (± 0.33%)}	_{2.47s (± 0.21%)}	_~	_2.47s	_2.48s	_{p=0.140 n=6}
_{Bind Time}	_{0.93s (± 0.56%)}	_{0.93s (± 0.68%)}	_~	_0.92s	_0.94s	_{p=0.386 n=6}
_{Check Time}	_{6.86s (± 0.52%)}	_{6.86s (± 0.34%)}	_~	_6.82s	_6.89s	_{p=0.871 n=6}
_{Emit Time}	_{4.05s (± 0.44%)}	_{4.04s (± 0.35%)}	_~	_4.02s	_4.06s	_{p=0.289 n=6}
_{Total Time}	_{14.30s (± 0.29%)}	_{14.30s (± 0.18%)}	_~	_14.27s	_14.33s	_{p=0.936 n=6}
_{TFS - node (v18.15.0, x64)}
_{Memory used}	_{302,771k (± 0.00%)}	_{302,772k (± 0.01%)}	_~	_302,754k	_302,797k	_{p=1.000 n=6}
_{Parse Time}	_{2.00s (± 1.14%)}	_{2.00s (± 0.88%)}	_~	_1.98s	_2.02s	_{p=0.568 n=6}
_{Bind Time}	_{1.00s (± 1.03%)}	_{1.00s (± 0.98%)}	_~	_0.99s	_1.02s	_{p=0.788 n=6}
_{Check Time}	_{6.31s (± 0.49%)}	_{6.31s (± 0.30%)}	_~	_6.29s	_6.33s	_{p=1.000 n=6}
_{Emit Time}	_{3.58s (± 0.50%)}	_{3.57s (± 0.46%)}	_~	_3.55s	_3.60s	_{p=0.618 n=6}
_{Total Time}	_{12.89s (± 0.22%)}	_{12.88s (± 0.13%)}	_~	_12.86s	_12.91s	_{p=0.516 n=6}
_{material-ui - node (v18.15.0, x64)}
_{Memory used}	_{508,265k (± 0.00%)}	_{519,661k (± 0.01%)}	_{+11,396k (+ 2.24%)}	_519,623k	_519,697k	_{p=0.005 n=6}
_{Parse Time}	_{2.58s (± 0.38%)}	_{2.60s (± 0.63%)}	_~	_2.57s	_2.61s	_{p=0.066 n=6}
_{Bind Time}	_{0.99s (± 0.76%)}	_{1.00s (± 0.52%)}	_~	_0.99s	_1.00s	_{p=0.247 n=6}
_{Check Time}	_{17.10s (± 0.39%)}	_{17.28s (± 0.12%)}	_{+0.18s (+ 1.04%)}	_17.25s	_17.30s	_{p=0.005 n=6}
_{Emit Time}	_{0.00s (± 0.00%)}	_{0.00s (± 0.00%)}	_~	_0.00s	_0.00s	_{p=1.000 n=6}
_{Total Time}	_{20.67s (± 0.30%)}	_{20.88s (± 0.12%)}	_{+0.21s (+ 1.00%)}	_20.85s	_20.91s	_{p=0.005 n=6}
_{xstate - node (v18.15.0, x64)}
_{Memory used}	_{512,979k (± 0.01%)}	_{513,370k (± 0.01%)}	_{+391k (+ 0.08%)}	_513,319k	_513,451k	_{p=0.005 n=6}
_{Parse Time}	_{3.28s (± 0.16%)}	_{3.28s (± 0.25%)}	_~	_3.27s	_3.29s	_{p=0.929 n=6}
_{Bind Time}	_{1.53s (± 0.34%)}	_{1.54s (± 0.27%)}	_~	_1.53s	_1.54s	_{p=0.112 n=6}
_{Check Time}	_{2.83s (± 0.27%)}	_{2.87s (± 0.61%)}	_{+0.03s (+ 1.24%)}	_2.85s	_2.90s	_{p=0.004 n=6}
_{Emit Time}	_{0.07s (± 5.69%)}	_{0.07s (± 0.00%)}	_~	_0.07s	_0.07s	_{p=0.405 n=6}
_{Total Time}	_{7.72s (± 0.23%)}	_{7.75s (± 0.27%)}	_{+0.03s (+ 0.39%)}	_7.73s	_7.79s	_{p=0.035 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Angular - node (v18.15.0, x64)
Compiler-Unions - node (v18.15.0, x64)
Monaco - node (v18.15.0, x64)
TFS - node (v18.15.0, x64)
material-ui - node (v18.15.0, x64)
xstate - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

tsserver

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-UnionsTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,343ms (± 0.26%)}	_{2,353ms (± 0.65%)}	_~	_2,341ms	_2,373ms	_{p=0.261 n=6}
_{Req 2 - geterr}	_{5,503ms (± 1.24%)}	_{5,496ms (± 1.12%)}	_~	_5,439ms	_5,577ms	_{p=0.810 n=6}
_{Req 3 - references}	_{322ms (± 0.54%)}	_{325ms (± 1.47%)}	_~	_321ms	_334ms	_{p=0.462 n=6}
_{Req 4 - navto}	_{274ms (± 1.43%)}	_{275ms (± 1.43%)}	_~	_270ms	_279ms	_{p=1.000 n=6}
_{Req 5 - completionInfo count}	_{1,356 (± 0.00%)}	_{1,356 (± 0.00%)}	_~	_1,356	_1,356	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{88ms (± 6.80%)}	_{87ms (± 4.76%)}	_~	_84ms	_92ms	_{p=0.666 n=6}
_{CompilerTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,465ms (± 1.21%)}	_{2,478ms (± 0.63%)}	_~	_2,461ms	_2,501ms	_{p=0.471 n=6}
_{Req 2 - geterr}	_{4,203ms (± 1.86%)}	_{4,131ms (± 1.48%)}	_~	_4,095ms	_4,254ms	_{p=0.228 n=6}
_{Req 3 - references}	_{337ms (± 1.67%)}	_{338ms (± 1.87%)}	_~	_329ms	_344ms	_{p=1.000 n=6}
_{Req 4 - navto}	_{284ms (± 0.29%)}	_{286ms (± 0.75%)}	_{+2ms (+ 0.76%)}	_284ms	_290ms	_{p=0.021 n=6}
_{Req 5 - completionInfo count}	_{1,518 (± 0.00%)}	_{1,518 (± 0.00%)}	_~	_1,518	_1,518	_{p=1.000 n=6}
_{Req 5 - completionInfo}	_{84ms (± 8.11%)}	_{85ms (± 8.59%)}	_~	_74ms	_90ms	_{p=0.492 n=6}
_{xstateTSServer - node (v18.15.0, x64)}
_{Req 1 - updateOpen}	_{2,604ms (± 0.23%)}	_{2,603ms (± 0.81%)}	_~	_2,578ms	_2,626ms	_{p=1.000 n=6}
_{Req 2 - geterr}	_{1,720ms (± 2.66%)}	_{1,733ms (± 2.01%)}	_~	_1,680ms	_1,764ms	_{p=0.520 n=6}
_{Req 3 - references}	_{116ms (± 9.66%)}	_{120ms (± 9.14%)}	_~	_105ms	_129ms	_{p=0.415 n=6}
_{Req 4 - navto}	_{365ms (± 0.11%)}	_{367ms (± 0.64%)}	_~	_365ms	_371ms	_{p=0.214 n=6}
_{Req 5 - completionInfo count}	_{2,073 (± 0.00%)}	_{2,074 (± 0.00%)}	_{+1 (+ 0.05%)}	_2,074	_2,074	_{p=0.001 n=6}
_{Req 5 - completionInfo}	_{307ms (± 1.94%)}	_{309ms (± 3.07%)}	_~	_297ms	_318ms	_{p=0.629 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

CompilerTSServer - node (v18.15.0, x64)
Compiler-UnionsTSServer - node (v18.15.0, x64)
xstateTSServer - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

startup

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{tsc-startup - node (v18.15.0, x64)}
_{Execution time}	_{154.51ms (± 0.20%)}	_{154.51ms (± 0.18%)}	_~	_153.40ms	_157.43ms	_{p=0.381 n=600}
_{tsserver-startup - node (v18.15.0, x64)}
_{Execution time}	_{229.70ms (± 0.16%)}	_{229.43ms (± 0.15%)}	_{-0.27ms (- 0.12%)}	_228.06ms	_233.03ms	_{p=0.000 n=600}
_{tsserverlibrary-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.93ms (± 0.18%)}	_{230.83ms (± 0.18%)}	_{-0.09ms (- 0.04%)}	_229.16ms	_235.11ms	_{p=0.012 n=600}
_{typescript-startup - node (v18.15.0, x64)}
_{Execution time}	_{230.89ms (± 0.17%)}	_{230.87ms (± 0.22%)}	_~	_229.30ms	_240.67ms	_{p=0.072 n=600}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

tsc-startup - node (v18.15.0, x64)
tsserver-startup - node (v18.15.0, x64)
tsserverlibrary-startup - node (v18.15.0, x64)
typescript-startup - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2024-01-12T15:44:53Z

Hey @sandersn, the results of running the DT tests are ready.
There were interesting changes:

Branch only errors:

Package: dygraphs
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/dygraphs/dygraphs-tests.ts
  109:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  125:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  129:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  139:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  233:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  258:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  271:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  284:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  297:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  304:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect

✖ 10 problems (10 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: keymaster
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/keymaster/test/keymaster-test-global.ts
  2:5  error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect

/home/vsts/work/1/DefinitelyTyped/types/keymaster/test/keymaster-tests.ts
  10:5  error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  14:5  error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: simulant
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/simulant/simulant-tests.ts
  3:1  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  4:1  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  6:1  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  7:1  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect

✖ 4 problems (4 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: zoomist
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/zoomist/zoomist-tests.ts
  52:13  error  TypeScript@local expected type to be:
  (e: Event) => void
got:
  (e: Event<EventTarget>) => void                        @definitelytyped/expect
  56:13  error  TypeScript@local expected type to be:
  (t: {}, e: Event) => void
got:
  (t: {}, e: Event<EventTarget>) => void          @definitelytyped/expect
  61:13  error  TypeScript@local expected type to be:
  (t: {}, e: Event) => void
got:
  (t: {}, e: Event<EventTarget>) => void          @definitelytyped/expect
  66:13  error  TypeScript@local expected type to be:
  (t: {}, e: Event) => void
got:
  (t: {}, e: Event<EventTarget>) => void          @definitelytyped/expect
  71:13  error  TypeScript@local expected type to be:
  (v: number, e: Event) => void
got:
  (v: number, e: Event<EventTarget>) => void  @definitelytyped/expect
  76:13  error  TypeScript@local expected type to be:
  (v: number, e: Event) => void
got:
  (v: number, e: Event<EventTarget>) => void  @definitelytyped/expect
  81:13  error  TypeScript@local expected type to be:
  (v: number, e: Event) => void
got:
  (v: number, e: Event<EventTarget>) => void  @definitelytyped/expect
  86:13  error  TypeScript@local expected type to be:
  (e: Event) => void
got:
  (e: Event<EventTarget>) => void                        @definitelytyped/expect
  90:13  error  TypeScript@local expected type to be:
  (e: Event) => void
got:
  (e: Event<EventTarget>) => void                        @definitelytyped/expect
  94:13  error  TypeScript@local expected type to be:
  (e: Event) => void
got:
  (e: Event<EventTarget>) => void                        @definitelytyped/expect

✖ 10 problems (10 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: jsoneditor
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/jsoneditor/jsoneditor-tests.ts
  236:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  242:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  248:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect

✖ 3 problems (3 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: nowigence-react-simple-maps
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/nowigence-react-simple-maps/nowigence-react-simple-maps-tests.tsx
  24:17  error  TypeScript@local expected type to be:
  WheelEvent
got:
  WheelEvent<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: rails__ujs
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/rails__ujs/rails__ujs-tests.ts
  42:9  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: page
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/page/page-tests.ts
  111:1  error  TypeScript@local expected type to be:
  (e: MouseEvent) => void
got:
  (e: MouseEvent<EventTarget>) => void  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: reveal.js
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/reveal.js/reveal.js-tests.ts
  689:1  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: amap-js-api-place-search
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/amap-js-api-place-search/amap-js-api-place-search-tests.ts
  412:5  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: jsdom
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/jsdom/jsdom-tests.ts
  24:1  error  TypeScript@local expected type to be:
  InputEvent
got:
  InputEvent<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: cookiebot-sdk
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/cookiebot-sdk/cookiebot-sdk-tests.ts
  28:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  32:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  36:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  40:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  44:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  48:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect
  52:5  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>  @definitelytyped/expect

✖ 7 problems (7 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: raphael
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/raphael/test/raphael-tests-api.ts
   575:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   598:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   625:13  error  TypeScript@local expected type to be:
  DragEvent
got:
  DragEvent<EventTarget>    @definitelytyped/expect
   635:13  error  TypeScript@local expected type to be:
  DragEvent
got:
  DragEvent<EventTarget>    @definitelytyped/expect
   641:13  error  TypeScript@local expected type to be:
  DragEvent
got:
  DragEvent<EventTarget>    @definitelytyped/expect
   746:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   752:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   808:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   826:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   844:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   862:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
   880:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1006:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1024:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1042:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1060:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1086:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1104:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1126:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1132:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1174:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1192:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1210:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1228:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1246:9   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>  @definitelytyped/expect
  1264:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1282:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1300:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect
  1318:9   error  TypeScript@local expected type to be:
  TouchEvent
got:
  TouchEvent<EventTarget>  @definitelytyped/expect

✖ 29 problems (29 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: yaireo__tagify
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/yaireo__tagify/yaireo__tagify-tests.ts
   78:13  error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>        @definitelytyped/expect
  141:13  error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  211:13  error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>                  @definitelytyped/expect
  217:13  error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  653:5   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>        @definitelytyped/expect
  659:5   error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  665:5   error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  701:5   error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>                  @definitelytyped/expect
  849:5   error  TypeScript@local expected type to be:
  MouseEvent
got:
  MouseEvent<EventTarget>        @definitelytyped/expect
  855:5   error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  861:5   error  TypeScript@local expected type to be:
  KeyboardEvent
got:
  KeyboardEvent<EventTarget>  @definitelytyped/expect
  897:5   error  TypeScript@local expected type to be:
  Event
got:
  Event<EventTarget>                  @definitelytyped/expect

✖ 12 problems (12 errors, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

Package: react-simple-maps
Error:

Error: 
/home/vsts/work/1/DefinitelyTyped/types/react-simple-maps/react-simple-maps-tests.tsx
  24:17  error  TypeScript@local expected type to be:
  WheelEvent
got:
  WheelEvent<EventTarget>  @definitelytyped/expect

✖ 1 problem (1 error, 0 warnings)

    at testTypesVersion (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:166:15)
    at async runTests (/home/vsts/work/1/DefinitelyTyped/node_modules/.pnpm/@[email protected][email protected]/node_modules/@definitelytyped/dtslint/dist/index.js:125:9)

You can check the log here.

typescript-bot · 2024-01-12T16:05:16Z

@sandersn Here are the results of running the top-repos suite comparing main and refs/pull/57040/merge:

Something interesting changed - please have a look.

Details

chakra-ui/chakra-ui

4 of 28 projects failed to build with the old tsc and were ignored

packages/components/tsconfig.build.json

error TS5056: Cannot write file '/mnt/ts_downloads/chakra-ui/packages/components/dist/types/menu/menu.stories.d.ts' because it would be overwritten by multiple input files.
- Project Scope

pixijs/pixijs

tsconfig.json

error TS2430: Interface 'ICanvasRenderingContext2D' incorrectly extends interface 'CanvasTextDrawingStyles'.
- packages/settings/src/ICanvasRenderingContext2D.ts#L7

tsconfig.types.json

error TS2430: Interface 'ICanvasRenderingContext2D' incorrectly extends interface 'CanvasTextDrawingStyles'.
- packages/settings/src/ICanvasRenderingContext2D.ts#L7

vercel/hyper

2 of 3 projects failed to build with the old tsc and were ignored

tsconfig.json

error TS2320: Interface 'CompositionEvent<T>' cannot simultaneously extend types 'UIEvent<T>' and 'Event<EventTarget>'.
- file:///built/local/lib.dom.d.ts#L5742 in app/tsconfig.json
- file:///built/local/lib.dom.d.ts#L5742 in app/tsconfig.json
error TS2320: Interface 'DragEvent<T>' cannot simultaneously extend types 'MouseEvent<T>' and 'Event<EventTarget>'.
- file:///built/local/lib.dom.d.ts#L7483 in app/tsconfig.json
- file:///built/local/lib.dom.d.ts#L7483 in app/tsconfig.json
error TS2320: Interface 'FocusEvent<T>' cannot simultaneously extend types 'UIEvent<T>' and 'Event<EventTarget>'.
- file:///built/local/lib.dom.d.ts#L8522 in app/tsconfig.json
- file:///built/local/lib.dom.d.ts#L8522 in app/tsconfig.json
error TS2320: Interface 'KeyboardEvent<T>' cannot simultaneously extend types 'UIEvent<T>' and 'Event<EventTarget>'.
- file:///built/local/lib.dom.d.ts#L14406 in app/tsconfig.json
- file:///built/local/lib.dom.d.ts#L14406 in app/tsconfig.json
error TS2320: Interface 'MouseEvent<T>' cannot simultaneously extend types 'UIEvent<T>' and 'Event<EventTarget>'.
- file:///built/local/lib.dom.d.ts#L15613 in app/tsconfig.json
- file:///built/local/lib.dom.d.ts#L15613 in app/tsconfig.json
error TS2320: Interface 'PointerEvent<T>' cannot simultaneously extend types 'MouseEvent<T>' and 'Event<EventTarget>'.
- file:///built/local/lib.dom.d.ts#L17614 in app/tsconfig.json
- file:///built/local/lib.dom.d.ts#L17614 in app/tsconfig.json
error TS2320: Interface 'TouchEvent<T>' cannot simultaneously extend types 'UIEvent<T>' and 'Event<EventTarget>'.
- file:///built/local/lib.dom.d.ts#L22435 in app/tsconfig.json
- file:///built/local/lib.dom.d.ts#L22435 in app/tsconfig.json
error TS2320: Interface 'UIEvent<T>' cannot simultaneously extend types 'Event<T>' and 'Event<EventTarget>'.
- file:///built/local/lib.dom.d.ts#L22583 in app/tsconfig.json
- file:///built/local/lib.dom.d.ts#L22583 in app/tsconfig.json
error TS2320: Interface 'WheelEvent<T>' cannot simultaneously extend types 'MouseEvent<T>' and 'Event<EventTarget>'.
- file:///built/local/lib.dom.d.ts#L25617 in app/tsconfig.json
- file:///built/local/lib.dom.d.ts#L25617 in app/tsconfig.json

Test generic DOM events again

682ca9a

typescript-bot assigned sandersn Jan 12, 2024

typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jan 12, 2024

sandersn added the Experiment A fork with an experimental idea which might not make it into master label Jan 30, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test generic DOM events again #57040

Test generic DOM events again #57040

sandersn commented Jan 12, 2024

sandersn commented Jan 12, 2024

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024

bluebird

/mnt/ts_downloads/bluebird/tsconfig.json

puppeteer

packages/browsers/test/src/tsconfig.json

typescript-bot commented Jan 12, 2024

tsc

tsserver

startup

typescript-bot commented Jan 12, 2024

typescript-bot commented Jan 12, 2024

chakra-ui/chakra-ui

packages/components/tsconfig.build.json

pixijs/pixijs

tsconfig.json

tsconfig.types.json

vercel/hyper

tsconfig.json

Test generic DOM events again #57040

Are you sure you want to change the base?

Test generic DOM events again #57040

Conversation

sandersn commented Jan 12, 2024

sandersn commented Jan 12, 2024

typescript-bot commented Jan 12, 2024 • edited Loading

typescript-bot commented Jan 12, 2024 • edited Loading

typescript-bot commented Jan 12, 2024 • edited Loading

typescript-bot commented Jan 12, 2024 • edited Loading

typescript-bot commented Jan 12, 2024 • edited Loading

typescript-bot commented Jan 12, 2024 • edited Loading

typescript-bot commented Jan 12, 2024

/mnt/ts_downloads/bluebird/tsconfig.json

typescript-bot commented Jan 12, 2024

tsc

tsserver

startup

typescript-bot commented Jan 12, 2024

typescript-bot commented Jan 12, 2024

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024 •

edited

Loading

typescript-bot commented Jan 12, 2024 •

edited

Loading