DevCheck -CheckDependencies exitcode. Fix dependencies #4866
+56
−120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DrusTheAxe
added
the
area-Infrastructure
kythant
approved these changes
Nov 8, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
godlytalias
approved these changes
Nov 9, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…t.Windows.SDK.BuildTools. The tools are already present in the Windows Platform SDK so there shouldn't be a need for this addition. Hopefully this is the root problem behind the build failures
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Scottj1s
approved these changes
Nov 12, 2024
|
I think I understand why the build breaks. Fix is simple or less so, but either way invasive. Discussing with @godlytalias to understand which way I should pivot. Update RSN |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
… in .vcxproj, fixed explicit versions to use central versioning (eng\Version.*), removed unnecessary dependencies, removed compiler/linker settings set project wide (see Directory.Build.props), adding missing Copyright, etc. Same output (and hopefully build pipeline won't choke now)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DevCheck -CheckDependenciesspots package dependencies that don't match the sanctioned list ineng\Verison.*.xmlbut it didn't set the exitcode if violators found so builds would detect violators, printf some message in a wall of text no one looks at and continue on.Fixed to set exitcode so the build pipeline should abort if problem(s) are found
This turned up a few problems in the repo. Fixed (else this DevCheck fix couldn't be checked in)
TODO: something wrong with the WindowsAppRuntime_UniversalBGTaskDLL project