-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support to adoCodespacesAuth.tenantID extension setting for conf… #15
Adds support to adoCodespacesAuth.tenantID extension setting for conf… #15
Conversation
…igure the tenant to sign in to
@ronakj can you review this? |
Mostly looks good functionally. Just some minor code changes and we should be good to go. Can you also update the |
Thanks @liguori. I will do a quick test from my side and then release it. |
When testing this, it seems to not work when requesting token. It authenticates fine initially, but when you request a token with the command There are two reasons from what I can see. The PR breaks the default assumption that @liguori can you create a followup PR. Maybe move the logic for getting tenant from configuration to the You can test it by updating the version number, running Then signout, add the tenant id config and then signin to microsoft account. Run |
It's late for me today so I am gonna go, but I can also take a stab at fixing this tomorrow if you want. |
Provides the 'adoCodespacesAuth.tenantID' extension setting to configure the Entra ID tenant to sign in to.
Address #14