Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore logic for default scope if not provided in getAccessToken function #16

Merged
merged 9 commits into from
Feb 13, 2024

Conversation

liguori
Copy link
Member

@liguori liguori commented Feb 12, 2024

Before this change #15, the scope of 'getAccessToken' was optional: it was initialized to the value of DEFAULT_ADO_SCOPE.
The default value was missing in the absence of a scope from the other caller via socket (IPC)

@liguori
Copy link
Member Author

liguori commented Feb 12, 2024

@ronakj please review

@liguori liguori changed the title Fix: pass DEFAULT_ADO_SCOPE when token is requested via socket and scope is empty Restore logic for default scope if not provided in getAccessToken function Feb 12, 2024
@ronakj ronakj merged commit 70c4ad4 into microsoft:main Feb 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants