Leverage micromatch
to speed up glob matching
#911
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
micromatch
is faster thanminimatch
in performing matching.Which can be seen with auditable benchmarks here
I wanted to be 100% sure this would help this project and created two benchmark files of my own here trying to replicate some of the usecases of this project.
The results are :
Although the perceived speedup may be only seen in very large cases, we do see it is 50% improvement overall.
The current UT's work fine, happy to extend them if we have some worries about known edge cases or we just want more security.