Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor improvements to path include/exclude logic #915

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

ecraig12345
Copy link
Member

@ecraig12345 ecraig12345 commented Sep 1, 2023

Update getScopedPackages to skip the step of checking for package inclusion if there are only exclusion (negated) scope patterns specified. This should provide a minor efficiency improvement in large repos.

Also update isPathIncluded's include parameter (and the group include options that use it) to allow passing true instead of include pattern(s), to include all packages except those specified by exclude and skip some pattern checks.

Other changes:

  • Simplify isPathIncluded logic
  • Add more tests for isPathIncluded
  • Update docs for group exclude to clarify that exclusions must be specified as negated patterns for now (this is an incorrect design which should be fixed in a major version, tracked by Fix behavior of group "exclude" options #916)

@ecraig12345 ecraig12345 merged commit 527bf1a into master Sep 1, 2023
4 checks passed
@ecraig12345 ecraig12345 deleted the ecraig/path-included branch September 1, 2023 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant