Minor improvements to path include/exclude logic #915
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
getScopedPackages
to skip the step of checking for package inclusion if there are only exclusion (negated) scope patterns specified. This should provide a minor efficiency improvement in large repos.Also update
isPathIncluded
'sinclude
parameter (and the groupinclude
options that use it) to allow passingtrue
instead of include pattern(s), to include all packages except those specified byexclude
and skip some pattern checks.Other changes:
isPathIncluded
logicisPathIncluded
exclude
to clarify that exclusions must be specified as negated patterns for now (this is an incorrect design which should be fixed in a major version, tracked by Fix behavior of group "exclude" options #916)