Jb1/improper array index #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dilanbhalla
reviewed
Apr 17, 2024
| predicate isSource(DataFlow::Node source) { isFlowSource(source, _) } | ||
| predicate isSource(DataFlow::Node source) { | ||
| isFlowSource(source, _) and | ||
| not source.getLocation().getFile().getRelativePath().regexpMatch("(.*/)?tests?/.*") |
There was a problem hiding this comment.
Do we not have other ways of doing this (like some kind of filtering from Liquid post sarif generation)? If not, that's kind of crazy because we would need to add something like this to all of our queries, right? Or am I missing something
There was a problem hiding this comment.
Yes, and usually we wouldn't make such a change and just use the post-analysis finding filtering, however if a CodeQL rule generates over 2GB of data for an individual rule, the CLI will throw an exception and not complete and we are seeing instances of this. More detail in DM.
dilanbhalla
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Query
cpp/unclear-array-index-validation
Description
Filter out DataFlow nodes which occur in
~/\/tests?\//directories.