Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorder of dictionary values when loading from IConfiguration into a Dictionary<string,string> using bind #1420

Open
3GDXC opened this issue Nov 28, 2023 · 3 comments

Comments

@3GDXC
Copy link

3GDXC commented Nov 28, 2023

Configuration section
"Menu": {
"Home": "#",
"General Feedback": "/Questionnaire?form=1",
"Request Callback": "/Questionnaire?form=2",
"Raise Complaint": "/Questionnaire?form=3"
}

var menu = new Dictionary<string,string>();
configuration.Bind("Menu", menu);

foreach(var item in menu)
Console.WriteLine($"KEY :{item.Key}, VALUE: {item.Value}");

--- OUTPUT
KEY: General Feedback, VALUE: /Questionnaire?form=1
KEY: Home, VALUE: #
KEY: Raise Complaint, VALUE: /Questionnaire?form=3
KEY: Request Callback, VALUE: /Questionnaire?form=2

Note the order of the values has changed, and this is a unexpected behavior which can cause issues; please allow options to prevent reordering of values during the binding

@rahul-s-bhatt
Copy link

Hey @3GDXC I'm not a contributor or anything, so apologies if this sounds out of the blue...
But why is ordered matter here?

@3GDXC
Copy link
Author

3GDXC commented Jan 2, 2024

Hey @3GDXC I'm not a contributor or anything, so apologies if this sounds out of the blue... But why is ordered matter here?

the order is preserved as the configuration may be used for things like; menu items creation or middleware injection and doing so in the correct order would be wrong; a developer could of create a indexed object structure, but the behavior of config IMHO shouldn't introduce any ordering unless EXPLICITLY required by the developer.

@i-am-nikhil
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants