Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: show plugins and clients in panel #5784

Open
wants to merge 45 commits into
base: main
Choose a base branch
from
Open

Feature: show plugins and clients in panel #5784

wants to merge 45 commits into from

Conversation

thewahome
Copy link
Contributor

@thewahome thewahome commented Nov 15, 2024 •
edited
Loading

Overview

Closes #5715

Demo

image

Tasks

  • When there are clients and plugins in the current context, Kiota should show the Workspace panel expanded and listing all clients and plugins available
  • The "My workspace" panel must be in the top.
  • When there is no clients or plugins in the context, the Workspace panel should load collapsed when opening Kiota extension.
  • When there is no clients or plugins in the context and one expands the Workspace panel, we should show a "No clients or plugins are available" in the panel.
  • Only show the Clients component when there is at least 1 client in the current context. If no client was found, the node shouldn't be displayed.
  • Only show the Plugins component when there is at least 1 plugin in the current context. If no plugin was found, the node shouldn't be displayed.
  • Clients and Plugins components must to be expandable/collapsible.
  • When hovering the { } icon in any existing plugin/client, we should show the text Select. When clicking on it, the API Explorer should be loaded with the right client/plugin and right selected paths (same as the EditPaths codelense action)
  • When hovering the trash icon in any existing plugin/client, we should show the text Delete. When clicking on it for any existing plugin/client, the plugin remove should be performed.

Future work

  • the notification for regeneration should be displayed once an api is loaded.

@thewahome thewahome requested a review from a team as a code owner November 15, 2024 15:03
@thewahome thewahome marked this pull request as draft November 15, 2024 15:03
thewahome and others added 17 commits November 15, 2024 18:19
@thewahome
Merge branch 'main' into task/extension/show-plugins-and-clients-in-p…
7fbaeea 
…anel
@thewahome
Merge branch 'main' into task/extension/show-plugins-and-clients-in-p…
b285a33 
…anel
@thewahome
[partial] delete workspace item
711294c
reuse item generation
ab673e5
@thewahome
support workspace tree provider
232f108
@thewahome
don't clean output
5096870
@thewahome
add remove client async and remove plugin async functions to the RPC …
4ee59e7 
…server
@thewahome
connect to kiota rpc functions
0a6763f
@thewahome
isolate in folder
a104372
@thewahome
remove regeneration, change icon, call select
bca6af0
@thewahome
Merge branch 'main' into task/extension/show-plugins-and-clients-in-p…
693033a 
…anel
@thewahome
add logging dependency
cc8b44f
@thewahome
refresh view after deleting workspace item
72460cd
@thewahome
load works[ace content on refresh
8983f71
@thewahome
bump version numbrt to match kiota with changes
96095f0
@thewahome
use string formating
95f03bc
@thewahome
show no clients or plugins available message
ce5afbe
@thewahome thewahome marked this pull request as ready for review November 20, 2024 12:31
baywet
baywet requested changes Nov 21, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, now that we have a unit test infrastructure in place, we should make it a habit to include unit tests to get at least a basic coverage.

vscode/microsoft-kiota/src/commands/deleteWorkspaceItem/deleteWorkspaceItemCommand.ts Show resolved Hide resolved
vscode/microsoft-kiota/src/providers/workspaceTreeProvider.ts Outdated Show resolved Hide resolved
baywet
baywet previously approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@baywet baywet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the changes!

@thewahome thewahome force-pushed the task/extension/show-plugins-and-clients-in-panel branch from 9f4979a to 762484a Compare November 25, 2024 08:05
@thewahome thewahome requested a review from a team November 26, 2024 08:18
baywet
baywet previously approved these changes Nov 26, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baywet baywet baywet left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
Kiota
Status: In Progress 🚧
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kiota Workspace panel should list all clients and plugins available in the current VS code workspace
2 participants
@thewahome @baywet