Live Share Audio (unable to download needed dependencies) — TypeError

[coreygo]

Product and Version [VS/VSCode]:
1.39.0-insider,9414b7e75bdbef887c76cb603e542db2b86b99b7
OS Version [macOS/Windows]: macOS 10.14.6
Live Share Extension Version:
ms-vsliveshare.vsliveshare-1.0.766 and ms-vsliveshare.vsliveshare-audio-0.1.64
Target Platform or Language [e.g. Node.js]: N/A

Steps to Reproduce / Scenario:

1. Update to latest Code Insiders build.
2. Reload and receive error about being unable to download needed dependencies.
3. Uninstall both Live Share and Live Share Audio from Extensions.
4. rm -rf ~/.vscode-insiders/extensions/ms-vsliveshare*
5. Launch code-insiders; reinstall Live Share and Live Share Audio from Extensions.
6. Export Logs:

Contents of `VSLSAudio.log`

[2019-09-08 02:59:09.653 LiveShareAudio I] Installing dependencies for VSLS Audio...
[2019-09-08 02:59:09.655 LiveShareAudio I] Downloading package 'electron-mac-x64-skype-4.2.7' 
[2019-09-08 02:59:17.605 LiveShareAudio I] Download complete.
[2019-09-08 02:59:17.645 LiveShareAudio I] Skipping package 'slimcore-electron-signed-2019.23.01.1.tgz' (already downloaded).
[2019-09-08 02:59:17.645 LiveShareAudio I] Installing package 'electron-mac-x64-skype-4.2.7'
[2019-09-08 02:59:17.645 LiveShareAudio V] Installing package 'electron-mac-x64-skype-4.2.7' to: /Users/corey/Library/Application Support/Code - Insiders/User/globalStorage/ms-vsliveshare.vsliveshare-audio/electron-4.2.7/dist
[2019-09-08 02:59:17.709 LiveShareAudio I] Cleaned old files from install path.
[2019-09-08 02:59:25.842 LiveShareAudio V] Extracted packed files
[2019-09-08 02:59:25.857 LiveShareAudio E] Failed at stage: installPackages - Dependency download failed. TypeError: Cannot read property 'code' of null
[2019-09-08 03:02:48.352 LiveShareAudio I] Deactivating extension

7. Suspect Failed at stage: installPackages - Dependency download failed. TypeError: Cannot read property 'code' of null is the issue. The download worked; perhaps the package didn't extract correctly?
8. rm -rf ~/Library/Application Support/Code - Insiders/User/globalStorage/ms-vsliveshare* and also repeat step 4.
9. Launch code-insiders; reinstall Live Share and Live Share Audio from Extensions.

🎉 workaround successful, verified via Live Share logs:

Contents of `VSLSAudio.log`

[2019-09-08 03:04:27.761 LiveShareAudio I] Installing dependencies for VSLS Audio...
[2019-09-08 03:04:27.763 LiveShareAudio I] Downloading package 'electron-mac-x64-skype-4.2.7' 
[2019-09-08 03:04:35.148 LiveShareAudio I] Download complete.
[2019-09-08 03:04:35.211 LiveShareAudio I] Downloading package 'slimcore-electron-signed-2019.23.01.1.tgz' 
[2019-09-08 03:04:37.069 LiveShareAudio I] Download complete.
[2019-09-08 03:04:37.071 LiveShareAudio I] Installing package 'electron-mac-x64-skype-4.2.7'
[2019-09-08 03:04:37.071 LiveShareAudio V] Installing package 'electron-mac-x64-skype-4.2.7' to: /Users/corey/Library/Application Support/Code - Insiders/User/globalStorage/ms-vsliveshare.vsliveshare-audio/electron-4.2.7/dist
[2019-09-08 03:04:41.683 LiveShareAudio V] Extracted packed files
[2019-09-08 03:04:41.684 LiveShareAudio I] Finished installing.
[2019-09-08 03:04:41.693 LiveShareAudio I] Installing package 'slimcore-electron-signed-2019.23.01.1.tgz'
[2019-09-08 03:04:41.693 LiveShareAudio V] Installing package 'slimcore-electron-signed-2019.23.01.1.tgz' to: /Users/corey/Library/Application Support/Code - Insiders/User/globalStorage/ms-vsliveshare.vsliveshare-audio/slimcore-4.0
[2019-09-08 03:04:42.291 LiveShareAudio V] Extracted packed files
[2019-09-08 03:04:42.292 LiveShareAudio I] Finished installing.
[2019-09-08 03:04:42.295 ExternalAppCallingService I] Calling stack will be lazy loaded
[2019-09-08 03:04:42.296 LiveShareAudio V] Current state: Initializing, Action: InitializeDone

[coreygo]

#2475 is similar but doesn't mention the extraction issue. #2660 and #2071 are also similar.

#2663 appears to be the same issue (although not against an Insiders build); in theory, the above workaround around might work.

Peace 🖖

[jramsay]

@coreygo : thanks for filing this! There was indeed a problem with our dependency downloader that could occur after VS Code updates. The latest Live Share Audio extension (v.0.1.66) contains a fix for the issue. Appreciate your help with this!

[coreygo]

Glad to help.

No issues updating to 1.39.0-insider,55825e9ad2aa4b4b3f8b2290a54a517bc454a7a5.

ms-vsliveshare.vsliveshare-audio,0.1.66 works correctly.