try a newer xdp build #4590
Draft
try a newer xdp build #4590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4590 +/- ##
==========================================
- Coverage 85.88% 85.68% -0.21%
==========================================
Files 56 56
Lines 17354 17354
==========================================
- Hits 14904 14869 -35
- Misses 2450 2485 +35 ☔ View full report in Codecov by Sentry. |
nibanks
reviewed
Oct 8, 2024
| "[ xdp][%p] XDP loading library", | ||
| Xdp); | ||
|
|
||
| HMODULE Lib = LoadLibraryA("xdpapi.dll"); |
There was a problem hiding this comment.
I thought we already had dynamic loading for xdp...?
There was a problem hiding this comment.
I think the problem is that XdpLoadApi below did not return a meaningful error code to understand the precise stage loading failed, and this added diagnostics.
There was a problem hiding this comment.
[This whole problem is moot with even newer builds.]
nibanks
reviewed
Oct 8, 2024
| @@ -176,6 +176,10 @@ RawSocketCreateUdp( | |||
| return Status; | |||
| } | |||
|
|
|||
| // | |||
| // Change some real code, too. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the purpose of and changes within this Pull Request.
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?