Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OOB Connection Feature #4644

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

OOB Connection Feature #4644

wants to merge 3 commits into from

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Nov 3, 2024

Description

This is an exploratory PR to see what is involved to create an 'out of band connection' interface, which allows a server to provide a byte buffer (out of band) to a client that allows it to directly connect without going through the handshake.

Testing

New test case added

Documentation

TODO

@nibanks nibanks added Area: API Area: Core Related to the shared, core protocol logic labels Nov 3, 2024
Copy link

codecov bot commented Nov 3, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 85.52%. Comparing base (14810af) to head (b4ecfc7).

Files with missing lines Patch % Lines
src/core/connection.c 37.50% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4644      +/-   ##
==========================================
- Coverage   87.22%   85.52%   -1.71%     
==========================================
  Files          56       56              
  Lines       17354    17364      +10     
==========================================
- Hits        15137    14850     -287     
- Misses       2217     2514     +297     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: API Area: Core Related to the shared, core protocol logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant